Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vite] Iron-icon doesn't work, due to a problem in esbuild #12262

Open
gilberto-torrezan opened this issue Nov 3, 2021 · 2 comments
Open

[Vite] Iron-icon doesn't work, due to a problem in esbuild #12262

gilberto-torrezan opened this issue Nov 3, 2021 · 2 comments
Assignees
@Artur-
Labels
bug Impact: Low Severity: Minor vite Tickets related to vite support

Comments

@gilberto-torrezan
Copy link
Contributor

Everything that depends on Polymer doesn't quite work well with Vite, but everything that is not iron-icon, there's an workaround for it.

Vaadin components that are based on Polymer don't have circular dependencies, so they happen to work without issues.

Reference: evanw/esbuild#399
@gilberto-torrezan gilberto-torrezan added bug vite Tickets related to vite support labels Nov 3, 2021
@Artur- Artur- self-assigned this Nov 15, 2021
@vursen
Copy link
Contributor

vursen commented Jan 26, 2022 •
edited
Loading

I tried to use Vite + an iron-icon in my Fusion project and didn't get any trouble with it. The icon was displayed on the page as well as no warnings by Vite. Perhaps it was already fixed at some point?

I also tried to build the app in production mode and everything worked all the same fine.

I created this very basic example so you could see it for yourself:
https://stackblitz.com/edit/vitejs-vite-nbknhm?file=main.js

Am I missing some context?

@Artur-
Copy link
Member

Artur- commented Jan 26, 2022

The related Vite issue is vitejs/vite#5142

@jdcoldsmith jdcoldsmith mentioned this issue Aug 17, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Artur- Artur-

Labels
bug Impact: Low Severity: Minor vite Tickets related to vite support
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Artur- @vursen @gilberto-torrezan @mshabarov