Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use slog, refactor #269

Merged
merged 1 commit into from
Dec 19, 2024
Merged

refactor: use slog, refactor #269

merged 1 commit into from
Dec 19, 2024

Conversation

utkuozdemir
Copy link
Owner

No description provided.

@utkuozdemir utkuozdemir force-pushed the refactor-stuff branch 2 times, most recently from fc2371b to 568772b Compare December 19, 2024 11:13
@utkuozdemir utkuozdemir marked this pull request as ready for review December 19, 2024 11:14
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 37.33333% with 47 lines in your changes missing coverage. Please review.

Project coverage is 66.92%. Comparing base (e84a75d) to head (4fd9918).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
cmd/nvidia_gpu_exporter/main.go 0.00% 29 Missing ⚠️
internal/exporter/exporter.go 60.86% 16 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #269      +/-   ##
==========================================
- Coverage   70.22%   66.92%   -3.31%     
==========================================
  Files           5        5              
  Lines         487      526      +39     
==========================================
+ Hits          342      352      +10     
- Misses        136      163      +27     
- Partials        9       11       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@utkuozdemir utkuozdemir force-pushed the refactor-stuff branch 2 times, most recently from 5816fab to 2e748e8 Compare December 19, 2024 11:24
Signed-off-by: Utku Ozdemir <utkuozdemir@gmail.com>
@utkuozdemir utkuozdemir merged commit b3668d6 into master Dec 19, 2024
2 checks passed
@utkuozdemir utkuozdemir deleted the refactor-stuff branch December 19, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant