Skip to content
This repository has been archived by the owner on Apr 28, 2024. It is now read-only.

Adapter\ClientSideValidationAdapter->rules has a misleading signiture #26

Open
@Silic0nS0ldier

Description

The first argument, $format is at conflict with the second, $stringEncode.

This leads to scenarios where you have code like

$validators->rules('json', false);

or

$validators->rules('json', true);

which makes it very difficult to predict what the output will be. In fact, this is happening within UF Core right now, where the latter example is used.

There is no way this problem could be addressed without a semver major change, as any action would result in potentially changed outputs.

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions