WIP: Relates to Closed PR #1134 and Issue #674. Add suri_path and password_path options to CLI #1602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ltfschoen Sorry for such a late answer, are you up for merging |
|
@cmichi sure, i can't right at the moment though as i'm about to board a long flight. i'll have plenty of time in a couple of weeks, but i'll try and look into it asap |
I've merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #674
inkorpallet-contracts?See description here #1134 (comment)
Allows user to provide either suri + password, or suri_path + password_path
Status
TODO's are included in the PR that I haven't been able to resolve, so I can't compile and update Cargo.lock
Description
Re-open PR #1134 that was previously closed.
See description here #1134 (comment)
Checklist before requesting a review
CHANGELOG.md