feat(core): Update defer/stream protocol as per spec #3389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8de3c3f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
JoviDeCroock
commented
Sep 26, 2023
JoviDeCroock
commented
Sep 26, 2023
Comment on lines
+180
to
+184
| if (payload.pending && !result) { | ||
| pending = payload.pending; | ||
| } else if (payload.pending) { | ||
| pending = [...pending!, ...payload.pending]; | ||
| } |
There was a problem hiding this comment.
Initially pending will be present on the ExecutionResult, however when we have nested incremental results then the IncrementalResult will contain new pending information which we have to add to our array here so we can keep building on our result
kitten
approved these changes
Sep 26, 2023
Co-authored-by: Phil Pluckthun <phil@kitten.sh>
kitten
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In the new June 2023 spec we get the introduction of
pendingon both incremental and execution results, pending contains an array of id and path.The id will be used in incremental payloads, we can then do a lookup in
pendingand find a path, the path indicates where the fragment got spread starting at the root.Another addition here is the
subPathwhich can be present on an incremental payload and builds on the path we can retrieve throughid, when deferred selection-sets are mixed with the non-deferred one this subPath will point at where we have to start merging.