Remove lint from non-relevant places #126
Conversation
Signed-off-by: Khosrow Moossavi <khos2ow@gmail.com>
khos2ow
changed the title
|
@hasheddan No, I should've converted it to draft a while ago. This is me attempting to move linting only to relevant CI jobs and targets. I was about to update this PR and consecutively open a corresponding PR in c/c. |
Signed-off-by: Khosrow Moossavi <khos2ow@gmail.com>
|
@negz @hasheddan this should be good for review now. |
| @@ -300,7 +300,6 @@ do.build.artifacts: $(foreach p,$(PLATFORMS), do.build.artifacts.$(p)) | |||
| # build for all platforms | |||
| build.all: | |||
| @$(MAKE) build.init | |||
| @$(MAKE) build.check | |||
There was a problem hiding this comment.
The most notable change here is that this line is removed. As I mentioned before this is really debatable. It's quite nice to have it executed as part of the build process, but at the same time the CI is in place and does that, separately on different job.
There was a problem hiding this comment.
One thing to note here is that this build submodule is used by several Upbound internal projects, so these changes could affect more than just Crossplane. :( I think we eventually should fork the build library under the Crossplane org so that folks without visibility into Upbound's private repos can make changes safely.
This was mentioned in crossplane/crossplane#1583, which I accidentally closed while only half done.
There was a problem hiding this comment.
That's a really valid point! Maybe as an interim workaround (before forking this under crossplane org) an environment variable can be added to disable this.
RUN_BUILD_CHECK ?=true
build.all:
@$(MAKE) build.init
ifeq ($(RUN_BUILD_CHECK),"true")
@$(MAKE) build.check
endif
Remove lint jobs and targets from processes and targets which they don't necessarily need to run lint. Notable changes:
make build:make build.checkwas removed from itmake helm.check: new target added for linting helm chartmake go.vendor.tidy: new target forgo mod tidywhich will be used in upstream projects' targets (e.g.make reviewable).This PR blocks crossplane/crossplane#1950 and should be reviewed as a pair.