Skip to content
This repository has been archived by the owner on Jun 2, 2019. It is now read-only.

Add TypeScript types #26

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

jaredpalmer
Copy link
Contributor

No description provided.

@karol-majewski
Copy link
Contributor

@jaredpalmer Thank you for your contribution! It's great to see a piece of work well done, especially when it's done by someone of your reputation.

As you may have noticed, this repository has not been actively maintained for quite some time now. We decided to keep it, but we can't afford to spend any more time on it.

However, because there is real value in having TypeScript definitions, it would be a shame to see them go to waste. What do you think about submitting them to DefinitelyTyped instead? This way the library consumers could benefit from them and everyone interested would be welcome to join the code review process, which should speed it up significantly.

Please let me know your thoughts.

@jaredpalmer
Copy link
Contributor Author

If this lib is not actively maintained anyways, better DX is to commit them here.

@karol-majewski
Copy link
Contributor

karol-majewski commented May 8, 2019

The reason I'm asking is that piece of advice from Daniel Rosenwasser:

mrsteele/dotenv-webpack#118 (comment)

It seems like there's more value in having the two separated.

Edit: just noticed this :D

image

@jaredpalmer
Copy link
Contributor Author

Cant argue with myself lol

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants