Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(preset-icons): add tests for loading custom svg icons #4089

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

test(preset-icons): add tests for loading custom svg icons #4089

wants to merge 1 commit into from

Conversation

serkodev
Copy link
Contributor

Related #4060, #4084

@netlify Netlify
Copy link

netlify bot commented Aug 21, 2024 •
edited
Loading

✅ Deploy Preview for unocss ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 66d444c
🔍 Latest deploy log https://app.netlify.com/sites/unocss/deploys/66c5f5e1dcf03b0008408fb4
😎 Deploy Preview https://deploy-preview-4089--unocss.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@serkodev serkodev marked this pull request as draft August 21, 2024 14:13
@serkodev serkodev mentioned this pull request Aug 21, 2024
Open
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Aug 21, 2024

commit: 66d444c

@unocss/astro

pnpm add https://pkg.pr.new/@unocss/astro@4089

@unocss/autocomplete

pnpm add https://pkg.pr.new/@unocss/autocomplete@4089

@unocss/cli

pnpm add https://pkg.pr.new/@unocss/cli@4089

@unocss/config

pnpm add https://pkg.pr.new/@unocss/config@4089

@unocss/core

pnpm add https://pkg.pr.new/@unocss/core@4089

@unocss/eslint-config

pnpm add https://pkg.pr.new/@unocss/eslint-config@4089

@unocss/eslint-plugin

pnpm add https://pkg.pr.new/@unocss/eslint-plugin@4089

@unocss/extractor-arbitrary-variants

pnpm add https://pkg.pr.new/@unocss/extractor-arbitrary-variants@4089

@unocss/extractor-mdc

pnpm add https://pkg.pr.new/@unocss/extractor-mdc@4089

@unocss/extractor-pug

pnpm add https://pkg.pr.new/@unocss/extractor-pug@4089

@unocss/extractor-svelte

pnpm add https://pkg.pr.new/@unocss/extractor-svelte@4089

@unocss/inspector

pnpm add https://pkg.pr.new/@unocss/inspector@4089

@unocss/nuxt

pnpm add https://pkg.pr.new/@unocss/nuxt@4089

@unocss/postcss

pnpm add https://pkg.pr.new/@unocss/postcss@4089

@unocss/preset-attributify

pnpm add https://pkg.pr.new/@unocss/preset-attributify@4089

@unocss/preset-icons

pnpm add https://pkg.pr.new/@unocss/preset-icons@4089

@unocss/preset-legacy-compat

pnpm add https://pkg.pr.new/@unocss/preset-legacy-compat@4089

@unocss/preset-mini

pnpm add https://pkg.pr.new/@unocss/preset-mini@4089

@unocss/preset-rem-to-px

pnpm add https://pkg.pr.new/@unocss/preset-rem-to-px@4089

@unocss/preset-tagify

pnpm add https://pkg.pr.new/@unocss/preset-tagify@4089

@unocss/preset-typography

pnpm add https://pkg.pr.new/@unocss/preset-typography@4089

@unocss/preset-uno

pnpm add https://pkg.pr.new/@unocss/preset-uno@4089

@unocss/preset-web-fonts

pnpm add https://pkg.pr.new/@unocss/preset-web-fonts@4089

@unocss/preset-wind

pnpm add https://pkg.pr.new/@unocss/preset-wind@4089

@unocss/reset

pnpm add https://pkg.pr.new/@unocss/reset@4089

@unocss/rule-utils

pnpm add https://pkg.pr.new/@unocss/rule-utils@4089

@unocss/runtime

pnpm add https://pkg.pr.new/@unocss/runtime@4089

@unocss/scope

pnpm add https://pkg.pr.new/@unocss/scope@4089

@unocss/svelte-scoped

pnpm add https://pkg.pr.new/@unocss/svelte-scoped@4089

@unocss/transformer-attributify-jsx

pnpm add https://pkg.pr.new/@unocss/transformer-attributify-jsx@4089

@unocss/transformer-attributify-jsx-babel

pnpm add https://pkg.pr.new/@unocss/transformer-attributify-jsx-babel@4089

@unocss/transformer-compile-class

pnpm add https://pkg.pr.new/@unocss/transformer-compile-class@4089

@unocss/transformer-directives

pnpm add https://pkg.pr.new/@unocss/transformer-directives@4089

@unocss/transformer-variant-group

pnpm add https://pkg.pr.new/@unocss/transformer-variant-group@4089

unocss

pnpm add https://pkg.pr.new/unocss@4089

@unocss/vite

pnpm add https://pkg.pr.new/@unocss/vite@4089

@unocss/webpack

pnpm add https://pkg.pr.new/@unocss/webpack@4089

Open in Stackblitz

@userquin
Copy link
Member

I guess we will need to add this https://github.com/iconify/iconify/blob/439a862a1a0f0679038a0272bf06a9f277a50756/packages/utils/src/loader/modern.ts#L42 here https://github.com/iconify/iconify/blob/439a862a1a0f0679038a0272bf06a9f277a50756/packages/utils/src/loader/custom.ts#L63

@serkodev serkodev mentioned this pull request Aug 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antfu antfu Awaiting requested review from antfu antfu is a code owner

@userquin userquin Awaiting requested review from userquin userquin is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@serkodev @userquin