Make specifying skins and capes from URLs opt-in #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the `AllowTextureFromURL` config option and makes it false by default. Admins can still set skins and capes by URL, via the front end or the API, regardless of this setting. Allowing users to specify textures via URL is a possible security concern and doesn't really improve the UX that much, so we should make it opt-in. For unmojang#116.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
AllowTextureFromURLconfig option and makes it false by default. Admins can still set skins and capes by URL, via the front end or the API, regardless of this setting. Allowing users to specify textures via URL is a possible security concern and doesn't reallyimprove the UX that much, so we should make it opt-in.
Resolves #116.