Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the zero index from VarZeroVec #5601

Merged
merged 9 commits into from
Oct 1, 2024
Merged

Remove the zero index from VarZeroVec #5601

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e3e5dd1
Remove METADATA_WIDTH: we're not using it, and if we want to use it w…
Manishearth Sep 25, 2024
9e85a34
Remove MAX_INDEX
Manishearth Sep 25, 2024
6885722
Remove the always-zero leading index on VarZeroVec's buffer format
Manishearth Sep 25, 2024
047a49a
Fix mutation code to handle index 0
Manishearth Sep 26, 2024
f2ce727
tests
Manishearth Sep 25, 2024
f8c4d38
datagen
Manishearth Sep 27, 2024
585cd2a
clog
Manishearth Sep 27, 2024
1cc0814
remove extra check
Manishearth Sep 27, 2024
27f2b23
mention msrv
Manishearth Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
clog
  • Loading branch information
@Manishearth
Manishearth committed Sep 30, 2024
commit 585cd2a21a551e91191057d56f74405c6858fd0e
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@
- `zerovec`
- This release has multiple changes that affect the bit representation of various types. Do not update to this release if you wish to retain stable data formats.
- Change the `VarZeroVecFormat` values shipped by default to use the same index and length width. This breaks data layout for all `VarZeroVec`s. (https://github.com/unicode-org/icu4x/pull/5594)
- Change the `VarZeroVec` format to not store a superfluous 0 index at the beginning of the index array. This breaks data layout for all `VarZeroVec`s (https://github.com/unicode-org/icu4x/pull/5601)
- Optimize `MultiFieldsULE` to not store a length anymore. This breaks data layout for any `#[make_varule]`-using struct with multiple variable-sized fields. (https://github.com/unicode-org/icu4x/pull/5593)
- `writeable`

Expand Down