Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix datagen to propagate extension keywords and aux keys to child locales #4533

Merged
merged 9 commits into from
Jan 31, 2024
Merged

Fix datagen to propagate extension keywords and aux keys to child locales #4533

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f5e3a4c
Change interior data model in select_locales_for_key
sffc Jan 20, 2024
8eac07a
Propagate extensions to child locales; add tests
sffc Jan 20, 2024
fa59849
Refactor and make work in Preresolved mode
sffc Jan 20, 2024
68ec048
Docs
sffc Jan 20, 2024
7ef53b2
cargo make testdata
sffc Jan 20, 2024
878fc12
Changelog
sffc Jan 20, 2024
bb07edf
clippy
sffc Jan 20, 2024
636fb63
Fix changelog
sffc Jan 20, 2024
661326c
Add more docs
sffc Jan 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add more docs
  • Loading branch information
@sffc
sffc authored Jan 23, 2024
commit 661326c876496ffbe6b49fc59bebe99482bb5027
7 changes: 5 additions & 2 deletions provider/datagen/src/driver.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -475,8 +475,11 @@ struct ExplicitImplicitLocaleSets {

/// Resolves the set of explicit langids and the supported locales into two sets of locales:
///
/// - `explicit` contains the explicit langids but with aux keys and extension keywords included
/// - `implcit` contains any locale reachable by fallback from an `explicit` locale
/// - `explicit` contains the explicit langids but with aux keys and extension keywords included.
/// For example, if `ar-SA` is requested (explicit langid), and `ar` and `ar-u-nu-latn` are supported,
/// then `ar-SA` and `ar-SA-u-nu-latn` will be returned as `explicit`.
/// - `implcit` contains all supported locales reachable by fallback from an `explicit` locale.
/// These locales can be included without increasing data payload size.
fn make_explicit_implicit_sets(
key: DataKey,
explicit_langids: &HashSet<LanguageIdentifier>,
Expand Down