Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refresh our codecov CI #2701

Open
zbraniecki opened this issue Oct 1, 2022 · 4 comments
Open

Refresh our codecov CI #2701

zbraniecki opened this issue Oct 1, 2022 · 4 comments
Labels
C-test-infra Component: Integration test infrastructure good first issue Good for newcomers
Milestone
Backlog ⟨P4⟩

Comments

@zbraniecki
Copy link
Member

Our codecov CI uses grcov with setup from before Rust started supporting instrument-coverage natively.

I'm going to check if we can get better coverage if we update to either use modern grcov or maybe use an alternative like https://github.com/taiki-e/cargo-llvm-cov
@zbraniecki zbraniecki self-assigned this Oct 1, 2022
@sffc sffc added backlog C-test-infra Component: Integration test infrastructure labels Oct 17, 2022
@sffc sffc added this to the Backlog milestone Dec 22, 2022
@sffc sffc removed the backlog label Dec 22, 2022
@sffc
Copy link
Member

sffc commented May 21, 2024

According to @ambiguousname we also need to update from v3 to v4 of the GitHub Action.

@sffc sffc added the good first issue Good for newcomers label May 21, 2024
sffc added a commit that referenced this issue May 21, 2024
@sffc
Disable the codecov job with TODO to re-enable
096c029 
See #2701
@sffc sffc mentioned this issue May 21, 2024
Merged
@ambiguousname
Copy link
Contributor

To clarify, the part of the workflow that needs upgrading is codecov/codecov-action@v3. Per https://github.com/marketplace/actions/codecov, a token is required for code coverage. That requires following this guide here, for whoever has access to the repo's secrets: https://docs.codecov.com/docs/github-2-getting-a-codecov-account-and-uploading-coverage

@ambiguousname
Copy link
Contributor

Although it seems like there's some redundancy in the workflow, since grcov seems to be able to push to both coveralls and codecov, so we could just remove the part of the workflow that pushes to codecov.

@sffc
Copy link
Member

sffc commented May 21, 2024

Good point! I changed #4922 to keep uploading to coveralls and just not codecov. I think we had it uploading to both tools because we couldn't decide which one was better.

sffc added a commit that referenced this issue May 21, 2024
@sffc
Disable the codecov job with TODO to re-enable (#4922)
772d8be 
See #2701
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-test-infra Component: Integration test infrastructure good first issue Good for newcomers
Projects
None yet
Milestone
Backlog ⟨P4⟩
Development

No branches or pull requests
3 participants
@zbraniecki @sffc @ambiguousname