Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests and/or fix large-magnitude numbers being converted to PluralOperands #2588

Open
sffc opened this issue Sep 20, 2022 · 2 comments
Open

Add tests and/or fix large-magnitude numbers being converted to PluralOperands #2588

sffc opened this issue Sep 20, 2022 · 2 comments
Labels
C-pluralrules Component: Plural rules good first issue Good for newcomers help wanted Issue needs an assignee S-small Size: One afternoon (small bug fix or enhancement) T-bug Type: Bad behavior, security, privacy
Milestone
Priority Backlog ...

Comments

@sffc
Copy link
Member

sffc commented Sep 20, 2022

From @markusicu:

How do you handle conversions from i128 and u128 types when you only have a u64 for the i, v, f operands? We truncate the high digits, and there are no CLDR rules for which that truncation makes a difference. But we can double check that this is indeed the case.

I should note that this also happens in string and FixedDecimal conversions. We should make sure we have consistent behavior across the board.

CC @zbraniecki
@sffc sffc added T-bug Type: Bad behavior, security, privacy good first issue Good for newcomers C-pluralrules Component: Plural rules S-small Size: One afternoon (small bug fix or enhancement) labels Sep 20, 2022
@sffc sffc added this to the ICU4X 1.1 milestone Sep 20, 2022
@sffc sffc modified the milestones: ICU4X 1.1, ICU4X 1.x Dec 22, 2022
@sffc
Copy link
Member Author

sffc commented Dec 22, 2022

CC @younies

@sffc sffc added the help wanted Issue needs an assignee label Dec 22, 2022
@younies younies self-assigned this Dec 22, 2022
@sffc sffc mentioned this issue Feb 26, 2024
Closed
@Harsh1s
Copy link
Contributor

Harsh1s commented Feb 26, 2024

Hi, I'd love working on this issue. Can you please assign this to me?

@sffc sffc mentioned this issue Mar 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-pluralrules Component: Plural rules good first issue Good for newcomers help wanted Issue needs an assignee S-small Size: One afternoon (small bug fix or enhancement) T-bug Type: Bad behavior, security, privacy
Projects
None yet
Milestone
Priority Backlog ⟨P3⟩
Development

No branches or pull requests
3 participants
@sffc @younies @Harsh1s