forked from sourcegraph/conc
-
Notifications
You must be signed in to change notification settings - Fork 0
/
Copy pathresult_error_pool_test.go
149 lines (131 loc) · 4.24 KB
/
result_error_pool_test.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
package pool_test
import (
"errors"
"fmt"
"strconv"
"sync/atomic"
"testing"
"time"
"github.com/sourcegraph/conc/pool"
"github.com/stretchr/testify/require"
)
func TestResultErrorPool(t *testing.T) {
t.Parallel()
err1 := errors.New("err1")
err2 := errors.New("err2")
t.Run("panics on configuration after init", func(t *testing.T) {
t.Run("before wait", func(t *testing.T) {
t.Parallel()
g := pool.NewWithResults[int]().WithErrors()
g.Go(func() (int, error) { return 0, nil })
require.Panics(t, func() { g.WithMaxGoroutines(10) })
})
t.Run("after wait", func(t *testing.T) {
t.Parallel()
g := pool.NewWithResults[int]().WithErrors()
g.Go(func() (int, error) { return 0, nil })
_, _ = g.Wait()
require.Panics(t, func() { g.WithMaxGoroutines(10) })
})
})
t.Run("wait returns no error if no errors", func(t *testing.T) {
t.Parallel()
g := pool.NewWithResults[int]().WithErrors()
g.Go(func() (int, error) { return 1, nil })
res, err := g.Wait()
require.NoError(t, err)
require.Equal(t, []int{1}, res)
})
t.Run("wait error if func returns error", func(t *testing.T) {
t.Parallel()
g := pool.NewWithResults[int]().WithErrors()
g.Go(func() (int, error) { return 0, err1 })
res, err := g.Wait()
require.Len(t, res, 0) // errored value is ignored
require.ErrorIs(t, err, err1)
})
t.Run("WithCollectErrored", func(t *testing.T) {
t.Parallel()
g := pool.NewWithResults[int]().WithErrors().WithCollectErrored()
g.Go(func() (int, error) { return 0, err1 })
res, err := g.Wait()
require.Len(t, res, 1) // errored value is collected
require.ErrorIs(t, err, err1)
})
t.Run("WithFirstError", func(t *testing.T) {
t.Parallel()
g := pool.NewWithResults[int]().WithErrors().WithFirstError()
synchronizer := make(chan struct{})
g.Go(func() (int, error) {
<-synchronizer
// This test has an intrinsic race condition that can be reproduced
// by adding a `defer time.Sleep(time.Second)` before the `defer
// close(synchronizer)`. We cannot guarantee that the group processes
// the return value of the second goroutine before the first goroutine
// exits in response to synchronizer, so we add a sleep here to make
// this race condition vanishingly unlikely. Note that this is a race
// in the test, not in the library.
time.Sleep(100 * time.Millisecond)
return 0, err1
})
g.Go(func() (int, error) {
defer close(synchronizer)
return 0, err2
})
res, err := g.Wait()
require.Len(t, res, 0)
require.ErrorIs(t, err, err2)
require.NotErrorIs(t, err, err1)
})
t.Run("wait error is all returned errors", func(t *testing.T) {
t.Parallel()
g := pool.NewWithResults[int]().WithErrors()
g.Go(func() (int, error) { return 0, err1 })
g.Go(func() (int, error) { return 0, nil })
g.Go(func() (int, error) { return 0, err2 })
res, err := g.Wait()
require.Len(t, res, 1)
require.ErrorIs(t, err, err1)
require.ErrorIs(t, err, err2)
})
t.Run("limit", func(t *testing.T) {
t.Parallel()
for _, maxConcurrency := range []int{1, 10, 100} {
t.Run(strconv.Itoa(maxConcurrency), func(t *testing.T) {
maxConcurrency := maxConcurrency // copy
t.Parallel()
g := pool.NewWithResults[int]().WithErrors().WithMaxGoroutines(maxConcurrency)
var currentConcurrent atomic.Int64
taskCount := maxConcurrency * 10
for i := 0; i < taskCount; i++ {
g.Go(func() (int, error) {
cur := currentConcurrent.Add(1)
if cur > int64(maxConcurrency) {
return 0, fmt.Errorf("expected no more than %d concurrent goroutine", maxConcurrency)
}
time.Sleep(time.Millisecond)
currentConcurrent.Add(-1)
return 0, nil
})
}
res, err := g.Wait()
require.Len(t, res, taskCount)
require.NoError(t, err)
require.Equal(t, int64(0), currentConcurrent.Load())
})
}
})
t.Run("reuse", func(t *testing.T) {
// Test for https://github.com/sourcegraph/conc/issues/128
p := pool.NewWithResults[int]().WithErrors()
p.Go(func() (int, error) { return 1, err1 })
results1, errs1 := p.Wait()
require.Empty(t, results1)
require.ErrorIs(t, errs1, err1)
p.Go(func() (int, error) { return 2, err2 })
results2, errs2 := p.Wait()
require.Empty(t, results2)
require.ErrorIs(t, errs2, err2)
require.NotErrorIs(t, errs2, err1)
})
}