Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: stricter typescript settings and some cleanup. #3910

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

chore: stricter typescript settings and some cleanup. #3910

wants to merge 6 commits into from

Conversation

Goldziher
Copy link
Collaborator

This PR does the following:

1- Update the root tsconfig.json file to have stricter settings.
2- Fix ensuing build issues.
3. Update the web app tsconfigs as well.

Why? Better to seperate this stuff out of the pnpm branch.

@codesandbox CodeSandbox
Copy link

codesandbox bot commented Dec 24, 2024

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 24, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 5b05fec

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Goldziher Goldziher requested a review from zbeyens December 24, 2024 21:56
@vercel Vercel
Copy link

vercel bot commented Dec 24, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
plate ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 25, 2024 5:51pm

Goldziher
Goldziher commented Dec 25, 2024
View reviewed changes
tsconfig.json Outdated Show resolved Hide resolved
@zbeyens @Goldziher
Update tsconfig.json
5b05fec 
Co-authored-by: Na'aman Hirschfeld <nhirschfeld@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zbeyens zbeyens Awaiting requested review from zbeyens

@12joan 12joan Awaiting requested review from 12joan

@felixfeng33 felixfeng33 Awaiting requested review from felixfeng33

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Goldziher @zbeyens