Skip to content

Commit

Permalink
Fix some lint warnings in gradle files
Browse files Browse the repository at this point in the history
  • Loading branch information
oakkitten committed Nov 23, 2024
1 parent afa24fa commit 333b839
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 6 deletions.
4 changes: 2 additions & 2 deletions app/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ android {
storePassword = project.properties["devStorePassword"] as String
keyAlias = project.properties["devKeyAlias"] as String
keyPassword = project.properties["devKeyPassword"] as String
} catch (e: Exception) {
} catch (_: Exception) {
project.logger.warn("WARNING: Set the values devStorefile, devStorePassword, " +
"devKeyAlias, and devKeyPassword " +
"in ~/.gradle/gradle.properties to sign the release.")
Expand All @@ -107,7 +107,7 @@ android {
"../cats/proguard-rules.pro")
// kotlinx-coroutines-core debug-only artifact
// see https://github.com/Kotlin/kotlinx.coroutines#avoiding-including-the-debug-infrastructure-in-the-resulting-apk
packagingOptions {
packaging {
resources.excludes += "DebugProbesKt.bin"
}
}
Expand Down
2 changes: 1 addition & 1 deletion build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ plugins {
}

fun isNonStable(version: String): Boolean {
val stableKeyword = listOf("RELEASE", "FINAL", "GA").any { version.toUpperCase().contains(it) }
val stableKeyword = listOf("RELEASE", "FINAL", "GA").any { version.uppercase().contains(it) }
val regex = "^[0-9,.v-]+(-r)?$".toRegex()
val isStable = stableKeyword || regex.matches(version)
return isStable.not()
Expand Down
5 changes: 2 additions & 3 deletions cats/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ android {
compileSdk = 34

defaultConfig {
targetSdk = 34
minSdk = 16
consumerProguardFile("proguard-rules.pro")
}
Expand All @@ -35,9 +34,9 @@ tasks.withType<JavaCompile> {

val args = arrayOf("-showWeaveInfo",
"-1.5",
"-inpath", destinationDir.toString(),
"-inpath", destinationDirectory.asFile.get().toString(),
"-aspectpath", classpath.asPath,
"-d", destinationDir.toString(),
"-d", destinationDirectory.asFile.get().toString(),
"-classpath", classpath.asPath,
"-bootclasspath", android.bootClasspath.joinToString(File.pathSeparator))

Expand Down

0 comments on commit 333b839

Please sign in to comment.