Merge pull request #415 from typhoeus/stubbing_headers

call on_headers and on_body when stubbed.
typhoeus · Nov 11, 2014 · b548985 · b548985
2 parents 04c6f10 + 107ccac
commit b548985
Show file tree

Hide file tree

Showing 4 changed files with 42 additions and 0 deletions.
diff --git a/lib/typhoeus/hydra/stubbable.rb b/lib/typhoeus/hydra/stubbable.rb
@@ -16,6 +16,8 @@ module Stubbable
       #   hydra.add(request)
       def add(request)
         if response = Expectation.response_for(request)
+          request.execute_headers_callbacks(response)
+          request.on_body.each{ |callback| callback.call(response.body, response) }
           request.finish(response)
         else
           super

diff --git a/lib/typhoeus/request/stubbable.rb b/lib/typhoeus/request/stubbable.rb
@@ -18,6 +18,8 @@ module Stubbable
       # @return [ Response ] The response.
       def run
         if response = Expectation.response_for(self)
+          execute_headers_callbacks(response)
+          self.on_body.each{ |callback| callback.call(response.body, response) }
           finish(response)
         else
           super

diff --git a/spec/typhoeus/hydra/stubbable_spec.rb b/spec/typhoeus/hydra/stubbable_spec.rb
@@ -14,6 +14,26 @@
     end
 
     context "when expectation found" do
+      it "calls on_headers callbacks" do
+        canary = :not_called
+        request.on_headers do
+          canary = :called
+        end
+        hydra.add(request)
+        hydra.run
+        expect(canary).to eq(:called)
+      end
+
+      it "calls on_body callbacks" do
+        canary = :not_called
+        request.on_body do
+          canary = :called
+        end
+        hydra.add(request)
+        hydra.run
+        expect(canary).to eq(:called)
+      end
+
       it "finishes response" do
         expect(request).to receive(:finish)
         hydra.add(request)

diff --git a/spec/typhoeus/request/stubbable_spec.rb b/spec/typhoeus/request/stubbable_spec.rb
@@ -13,6 +13,24 @@
     end
 
     context "when expectation found" do
+      it "calls on_headers callbacks" do
+        canary = :not_called
+        request.on_headers do
+          canary = :called
+        end
+        request.run
+        expect(canary).to eq(:called)
+      end
+
+      it "calls on_body callbacks" do
+        canary = :not_called
+        request.on_body do
+          canary = :called
+        end
+        request.run
+        expect(canary).to eq(:called)
+      end
+
       it "finishes request" do
         expect(request).to receive(:finish)
         request.run