Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: enable object-shorthand #9816

Merged
merged 3 commits into from
Aug 19, 2024
Merged

chore: enable object-shorthand #9816

merged 3 commits into from
Aug 19, 2024

Conversation

abrahamguo
Copy link
Contributor

PR Checklist

Overview

Enable object-shorthand (docs). 100% autofixable

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @abrahamguo!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Aug 19, 2024 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 92fd541
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/66c390f24319a500086addba
😎 Deploy Preview https://deploy-preview-9816--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 93 (🔴 down 6 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Aug 19, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 92fd541. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 29 targets

Sent with 💌 from NxCloud.

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Aug 19, 2024
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this 🧹

@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Aug 19, 2024
Josh-Cena
Josh-Cena approved these changes Aug 19, 2024
View reviewed changes
Copy link
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surprised we didn't have this!

kirkwaiblinger
kirkwaiblinger approved these changes Aug 19, 2024
View reviewed changes
Copy link
Member

@kirkwaiblinger kirkwaiblinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

@codecov Codecov
Copy link

codecov bot commented Aug 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@8c72a4f). Learn more about missing BASE report.
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #9816   +/-   ##
=======================================
  Coverage        ?   88.01%           
=======================================
  Files           ?      406           
  Lines           ?    13881           
  Branches        ?     4056           
=======================================
  Hits            ?    12218           
  Misses          ?     1354           
  Partials        ?      309
Flag Coverage Δ
unittest 88.01% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...rc/rules/no-unnecessary-boolean-literal-compare.ts 97.46% <ø> (ø)
...slint-plugin/src/rules/no-unnecessary-qualifier.ts 100.00% <ø> (ø)
...es/eslint-plugin/src/rules/no-unsafe-assignment.ts 94.26% <ø> (ø)
packages/eslint-plugin/src/rules/no-unsafe-call.ts 100.00% <ø> (ø)
packages/typescript-estree/src/convert.ts 28.90% <ø> (ø)
...pt-estree/src/parseSettings/createParseSettings.ts 80.28% <ø> (ø)

@Josh-Cena Josh-Cena merged commit 1c2938f into typescript-eslint:main Aug 19, 2024
57 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Josh-Cena Josh-Cena Josh-Cena approved these changes

@kirkwaiblinger kirkwaiblinger kirkwaiblinger approved these changes

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@abrahamguo @JoshuaKGoldberg @kirkwaiblinger @Josh-Cena