Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable no-void #9552

Merged
merged 5 commits into from
Jul 16, 2024
Merged

Conversation

abrahamguo
Copy link
Contributor

@abrahamguo abrahamguo commented Jul 12, 2024

PR Checklist

Overview

Enable no-void (docs)

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @abrahamguo!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Jul 12, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 741f9ba
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6696ca1923ec01000953609f
😎 Deploy Preview https://deploy-preview-9552--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (🟢 up 5 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jul 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.37%. Comparing base (2ffa591) to head (33a895b).
Report is 1 commits behind head on main.

Current head 33a895b differs from pull request most recent head 741f9ba

Please upload reports for the commit 741f9ba to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9552   +/-   ##
=======================================
  Coverage   88.37%   88.37%           
=======================================
  Files         419      419           
  Lines       14621    14621           
  Branches     4280     4280           
=======================================
  Hits        12922    12922           
  Misses       1375     1375           
  Partials      324      324           
Flag Coverage Δ
unittest 88.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

kirkwaiblinger
kirkwaiblinger previously approved these changes Jul 14, 2024
Copy link
Member

@kirkwaiblinger kirkwaiblinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🙂

@kirkwaiblinger kirkwaiblinger added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Jul 14, 2024
@JoshuaKGoldberg JoshuaKGoldberg merged commit 0d939a2 into typescript-eslint:main Jul 16, 2024
58 of 61 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants