Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable no-var #9551

Merged
merged 4 commits into from
Jul 21, 2024
Merged

chore: enable no-var #9551

merged 4 commits into from
Jul 21, 2024

Conversation

abrahamguo
Copy link
Contributor

@abrahamguo abrahamguo commented Jul 12, 2024

PR Checklist

Overview

Enable no-var (docs). 100% autofixable

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @abrahamguo!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Jul 12, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit a21f3b3
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/669d6144fe44060008faff1d
😎 Deploy Preview https://deploy-preview-9551--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 97 (🟢 up 3 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

nx-cloud bot commented Jul 12, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit a21f3b3. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

kirkwaiblinger
kirkwaiblinger previously approved these changes Jul 13, 2024
Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.45%. Comparing base (863eb86) to head (a21f3b3).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9551   +/-   ##
=======================================
  Coverage   88.45%   88.45%           
=======================================
  Files         422      422           
  Lines       14694    14694           
  Branches     4299     4299           
=======================================
  Hits        12997    12997           
  Misses       1372     1372           
  Partials      325      325           
Flag Coverage Δ
unittest 88.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@kirkwaiblinger kirkwaiblinger added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Jul 21, 2024
@Josh-Cena
Copy link
Member

(We may eventually have our extension rule but I don't see reasons to not enforce the current style.)

@Josh-Cena Josh-Cena merged commit cf6d9e9 into typescript-eslint:main Jul 21, 2024
62 of 65 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants