-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: enable @typescript-eslint/no-unused-expressions #9542
chore: enable @typescript-eslint/no-unused-expressions #9542
Conversation
Thanks for the PR, @abrahamguo! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 9847e9b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9542 +/- ##
=======================================
Coverage 88.37% 88.37%
=======================================
Files 419 419
Lines 14618 14620 +2
Branches 4279 4279
=======================================
+ Hits 12919 12921 +2
Misses 1375 1375
Partials 324 324
Flags with carried forward coverage won't be shown. Click here to find out more.
|
One question - According to #8914, we are going to add this to the recommended config. Would this PR be redundant then? |
I suppose so! But it's nice to have this in the interim I think. |
PR Checklist
Overview
Enable
@typescript-eslint/no-unused-expressions
(docs). This allows for more dogfooding, as well.