Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable @typescript-eslint/no-unused-expressions #9542

Merged

Conversation

abrahamguo
Copy link
Contributor

@abrahamguo abrahamguo commented Jul 11, 2024

PR Checklist

Overview

Enable @typescript-eslint/no-unused-expressions (docs). This allows for more dogfooding, as well.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @abrahamguo!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Jul 11, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 9847e9b
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/668f76c15156680008711d6e
😎 Deploy Preview https://deploy-preview-9542--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 95 (🔴 down 3 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

nx-cloud bot commented Jul 11, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 9847e9b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link

codecov bot commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.37%. Comparing base (d9dba42) to head (9847e9b).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9542   +/-   ##
=======================================
  Coverage   88.37%   88.37%           
=======================================
  Files         419      419           
  Lines       14618    14620    +2     
  Branches     4279     4279           
=======================================
+ Hits        12919    12921    +2     
  Misses       1375     1375           
  Partials      324      324           
Flag Coverage Δ
unittest 88.37% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...int-plugin/src/rules/strict-boolean-expressions.ts 98.90% <100.00%> (+<0.01%) ⬆️
...ages/eslint-plugin/src/rules/unified-signatures.ts 85.62% <100.00%> (+0.09%) ⬆️

@kirkwaiblinger
Copy link
Member

One question - According to #8914, we are going to add this to the recommended config. Would this PR be redundant then?

@JoshuaKGoldberg
Copy link
Member

One question - According to #8914, we are going to add this to the recommended config. Would this PR be redundant then?

I suppose so! But it's nice to have this in the interim I think.

@JoshuaKGoldberg JoshuaKGoldberg merged commit 5d895b7 into typescript-eslint:main Jul 20, 2024
70 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants