chore: enable prefer-object-spread #9541
Conversation
|
Thanks for the PR, @abrahamguo! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| @@ -317,7 +320,7 @@ export default createRule<Options, MessageIds>({ | |||
| }); | |||
| }, | |||
|
|
|||
| TSIndexedAccessType(node: TSESTree.TSIndexedAccessType) { | |||
| TSIndexedAccessType(node: TSESTree.TSIndexedAccessType): void { | |||
There was a problem hiding this comment.
@typescript-eslint/explicit-function-return-type began reporting on these once we stopped using Object.assign.
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 88ecc41. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9541 +/- ##
=======================================
Coverage 88.44% 88.45%
=======================================
Files 422 422
Lines 14692 14694 +2
Branches 4299 4299
=======================================
+ Hits 12995 12997 +2
Misses 1372 1372
Partials 325 325
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…refer-object-spread
…refer-object-spread
|
👋 @abrahamguo you've sent us a lot of great PRs recently and we want to send you some money as thanks (https://typescript-eslint.io/maintenance/contributor-tiers#community-reimbursements). I can't for the life of me find a personal email for you. Could you please email me at the email on my profile? 😄 |
PR Checklist
Overview
Enable
prefer-object-spread. All reports were auto-fixable. (docs)