Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable no-useless-call #9537

Merged
merged 2 commits into from
Jul 18, 2024

Conversation

abrahamguo
Copy link
Contributor

@abrahamguo abrahamguo commented Jul 10, 2024

PR Checklist

Overview

Enable no-useless-call (docs)

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @abrahamguo!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Jul 10, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit ef9c539
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6696cb052e3e72000842f1e3
😎 Deploy Preview https://deploy-preview-9537--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 77 (🔴 down 17 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Josh-Cena
Josh-Cena previously approved these changes Jul 10, 2024
kirkwaiblinger
kirkwaiblinger previously approved these changes Jul 11, 2024
@abrahamguo abrahamguo dismissed stale reviews from kirkwaiblinger and Josh-Cena via ef9c539 July 16, 2024 19:33
Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.37%. Comparing base (16392ab) to head (ef9c539).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9537   +/-   ##
=======================================
  Coverage   88.37%   88.37%           
=======================================
  Files         419      419           
  Lines       14621    14621           
  Branches     4280     4280           
=======================================
  Hits        12922    12922           
  Misses       1375     1375           
  Partials      324      324           
Flag Coverage Δ
unittest 88.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@JoshuaKGoldberg JoshuaKGoldberg merged commit 8258dae into typescript-eslint:main Jul 18, 2024
63 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants