fix(website): react key error on internal pages of website #9506
Conversation
|
Thanks for the PR, @y-hsgw! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 5678ddd. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9506 +/- ##
=======================================
Coverage 88.37% 88.37%
=======================================
Files 419 419
Lines 14618 14618
Branches 4279 4279
=======================================
Hits 12919 12919
Misses 1375 1375
Partials 324 324
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
[Praise] Always great to see a deduplication 😄 nice!
JoshuaKGoldberg
merged commit 03fe3db
into
typescript-eslint:main
|
Oh, dangit, I should have renamed this to |
PR Checklist
Overview
It appears that the error occurred due to the presence of a key in the previous version of
LineInputProps. This issue has been resolved by updating the prism-react-renderer version.※I determined that the impact area is limited, as prism-react-renderer is used only in
packages/website/src/theme/CodeBlock/Content/String.tsx. Therefore, I proceeded with a major update. Please advise on the appropriate flow for updating package versions if there is a recommended procedure.