Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update to latest nx and use project references first approach #10361

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

chore: update to latest nx and use project references first approach #10361

wants to merge 15 commits into from

Conversation

JamesHenry
Copy link
Member

@JamesHenry JamesHenry commented Nov 20, 2024 •
edited by JoshuaKGoldberg
Loading

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JamesHenry!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Nov 20, 2024 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit a425794
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/677566766cfcc600081bc5c8
😎 Deploy Preview https://deploy-preview-10361--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 99 (🟢 up 8 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Nov 20, 2024 •
edited
Loading

View your CI Pipeline Execution ↗ for commit a425794.

Command Status Duration Result
nx test eslint-plugin --coverage=false ✅ Succeeded 7m 16s View ↗
nx test eslint-plugin ✅ Succeeded 5m 51s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded 1m 12s View ↗
nx test typescript-estree ✅ Succeeded 58s View ↗
nx test visitor-keys --coverage=false ✅ Succeeded 4s View ↗
nx test type-utils ✅ Succeeded 18s View ↗
nx run types:build ✅ Succeeded <1s View ↗
nx test visitor-keys ✅ Succeeded 2s View ↗
Additional runs (22) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-01-01 16:17:28 UTC

@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Nov 24, 2024
Open
This was referenced Dec 17, 2024
Closed
Open
@codecov Codecov
Copy link

codecov bot commented Dec 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.90%. Comparing base (4dbf48b) to head (a425794).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #10361   +/-   ##
=======================================
  Coverage   86.90%   86.90%           
=======================================
  Files         446      446           
  Lines       15502    15504    +2     
  Branches     4516     4516           
=======================================
+ Hits        13472    13474    +2     
  Misses       1675     1675           
  Partials      355      355
Flag Coverage Δ
unittest 86.90% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/eslint-plugin/src/rules/ban-ts-comment.ts 100.00% <ø> (ø)
...-plugin/src/rules/explicit-member-accessibility.ts 97.61% <ø> (ø)
...es/eslint-plugin/src/rules/no-invalid-void-type.ts 97.82% <ø> (ø)
...ges/eslint-plugin/src/rules/no-misused-promises.ts 97.73% <ø> (ø)
...es/eslint-plugin/src/rules/no-use-before-define.ts 97.00% <ø> (ø)
packages/eslint-plugin/src/rules/typedef.ts 98.63% <100.00%> (+0.01%) ⬆️
packages/rule-tester/src/RuleTester.ts 74.63% <100.00%> (+0.06%) ⬆️
packages/rule-tester/src/TestFramework.ts 46.26% <ø> (ø)
...kages/scope-manager/src/referencer/ClassVisitor.ts 79.00% <ø> (ø)
...e-manager/src/scope/FunctionExpressionNameScope.ts 100.00% <ø> (ø)
... and 3 more

@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Dec 31, 2024
Open
JoshuaKGoldberg
JoshuaKGoldberg reviewed Dec 31, 2024
View reviewed changes
knip.ts
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg Dec 31, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect a lot of the seemingly unnecessary includes in this file are due to webpro-nl/knip#873. Once that's resolved & released, if they're still there, we should file an issue over on Knip.

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review January 1, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Repo: Refactor TSConfigs to use project references
3 participants
@JamesHenry @JoshuaKGoldberg @leosvelperez