fix(eslint-plugin): report deprecations used in default export #10330

wszydlak · 2024-11-14T12:22:37Z

PR Checklist

Addresses an existing open issue: fixes Bug: [no-deprecated] Rule doesn't report on call inside default export #10327
That issue was marked as accepting prs
Steps in Contributing were taken

Overview

Report deprecations which are used in default exports - this is the way typescript compiler reports deprecations.

typescript-eslint · 2024-11-14T12:22:40Z

Thanks for the PR, @wszydlak!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

netlify · 2024-11-14T12:22:52Z

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	`3c93715`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/67383777b1ff1c0008abb432
😎 Deploy Preview	https://deploy-preview-10330--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 98 (🔴 down 1 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

nx-cloud · 2024-11-14T12:23:36Z

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 3c93715. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

packages/eslint-plugin/src/rules/no-deprecated.ts

JoshuaKGoldberg

Thanks for starting this! 🙌

codecov · 2024-11-14T19:54:38Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.69%. Comparing base (0f9a2a3) to head (3c93715).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #10330   +/-   ##
=======================================
  Coverage   86.69%   86.69%           
=======================================
  Files         434      434           
  Lines       15222    15222           
  Branches     4445     4445           
=======================================
  Hits        13196    13196           
  Misses       1670     1670           
  Partials      356      356

Flag	Coverage Δ
unittest	`86.69% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
packages/eslint-plugin/src/rules/no-deprecated.ts	`94.11% <ø> (ø)`

JoshuaKGoldberg

Good invalid test, thanks! Just asking about valid.

JoshuaKGoldberg

💯 thanks!

kirkwaiblinger · 2024-11-15T22:33:05Z

packages/eslint-plugin/tests/rules/no-deprecated.test.ts

@@ -100,6 +100,16 @@ ruleTester.run('no-deprecated', rule, {

      a('b');
    `,
+    `


This test is a fine test of overloaded function signature logic! I'm happy for us to keep it around, but I think for the sake of this issue we should also have a test purely for the default export usage that's as simple as

function notDeprecated() { return {}; } export default notDeprecated();

Added additional valid test 🙂

fixes typescript-eslint#10327

kirkwaiblinger

Thanks! 👍

@developer-bandi

##### [v8.15.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8150-2024-11-18) ##### 🚀 Features - **eslint-plugin:** \[prefer-nullish-coalescing] fix detection of `ignoreConditionalTests` involving boolean `!` operator ([#10299](typescript-eslint/typescript-eslint#10299)) - **eslint-plugin:** new rule `no-unsafe-type-assertion` ([#10051](typescript-eslint/typescript-eslint#10051)) - **eslint-plugin:** added related-getter-setter-pairs rule ([#10192](typescript-eslint/typescript-eslint#10192)) ##### 🩹 Fixes - **utils:** add defaultOptions to meta in rule ([#10339](typescript-eslint/typescript-eslint#10339)) - **eslint-plugin:** report deprecations used in default export ([#10330](typescript-eslint/typescript-eslint#10330)) - **eslint-plugin:** \[explicit-module-boundary-types] and \[explicit-function-return-type] don't report on `as const satisfies` ([#10315](typescript-eslint/typescript-eslint#10315)) - **eslint-plugin:** \[await-thenable, return-await] don't flag awaiting unconstrained type parameter as unnecessary ([#10314](typescript-eslint/typescript-eslint#10314)) - **eslint-plugin:** \[consistent-indexed-object-style] handle circular mapped types ([#10301](typescript-eslint/typescript-eslint#10301)) ##### ❤️ Thank You - Josh Goldberg ✨ - Kim Sang Du [@developer-bandi](https://github.com/developer-bandi) - Luis Sebastian Urrutia Fuentes [@LuisUrrutia](https://github.com/LuisUrrutia) - Phillip Huang - Ronen Amiel - Szydlak [@wszydlak](https://github.com/wszydlak) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

@developer-bandi

| datasource | package | from | to | | ---------- | -------------------------------- | ------ | ------ | | npm | @typescript-eslint/eslint-plugin | 8.14.0 | 8.15.0 | | npm | @typescript-eslint/parser | 8.14.0 | 8.15.0 | ## [v8.15.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8150-2024-11-18) ##### 🚀 Features - **eslint-plugin:** \[prefer-nullish-coalescing] fix detection of `ignoreConditionalTests` involving boolean `!` operator ([#10299](typescript-eslint/typescript-eslint#10299)) - **eslint-plugin:** new rule `no-unsafe-type-assertion` ([#10051](typescript-eslint/typescript-eslint#10051)) - **eslint-plugin:** added related-getter-setter-pairs rule ([#10192](typescript-eslint/typescript-eslint#10192)) ##### 🩹 Fixes - **utils:** add defaultOptions to meta in rule ([#10339](typescript-eslint/typescript-eslint#10339)) - **eslint-plugin:** report deprecations used in default export ([#10330](typescript-eslint/typescript-eslint#10330)) - **eslint-plugin:** \[explicit-module-boundary-types] and \[explicit-function-return-type] don't report on `as const satisfies` ([#10315](typescript-eslint/typescript-eslint#10315)) - **eslint-plugin:** \[await-thenable, return-await] don't flag awaiting unconstrained type parameter as unnecessary ([#10314](typescript-eslint/typescript-eslint#10314)) - **eslint-plugin:** \[consistent-indexed-object-style] handle circular mapped types ([#10301](typescript-eslint/typescript-eslint#10301)) ##### ❤️ Thank You - Josh Goldberg ✨ - Kim Sang Du [@developer-bandi](https://github.com/developer-bandi) - Luis Sebastian Urrutia Fuentes [@LuisUrrutia](https://github.com/LuisUrrutia) - Phillip Huang - Ronen Amiel - Szydlak [@wszydlak](https://github.com/wszydlak) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

JoshuaKGoldberg reviewed Nov 14, 2024

View reviewed changes

packages/eslint-plugin/src/rules/no-deprecated.ts Outdated Show resolved Hide resolved

JoshuaKGoldberg requested changes Nov 14, 2024

View reviewed changes

JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label Nov 14, 2024

wszydlak force-pushed the wszydlak-patch-1 branch from 05c93f4 to d215dd5 Compare November 14, 2024 19:54

wszydlak force-pushed the wszydlak-patch-1 branch 3 times, most recently from b13473b to 1c0fa10 Compare November 14, 2024 20:36

wszydlak requested a review from JoshuaKGoldberg November 14, 2024 20:52

github-actions bot removed the awaiting response Issues waiting for a reply from the OP or another party label Nov 14, 2024

JoshuaKGoldberg requested changes Nov 15, 2024

View reviewed changes

JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label Nov 15, 2024

wszydlak force-pushed the wszydlak-patch-1 branch from 1c0fa10 to fffa970 Compare November 15, 2024 18:33

JoshuaKGoldberg previously approved these changes Nov 16, 2024

View reviewed changes

JoshuaKGoldberg added 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge and removed awaiting response Issues waiting for a reply from the OP or another party labels Nov 16, 2024

kirkwaiblinger reviewed Nov 16, 2024

View reviewed changes

fix(eslint-plugin): report deprecations used in default export

3c93715

fixes typescript-eslint#10327

wszydlak dismissed JoshuaKGoldberg’s stale review via 3c93715 November 16, 2024 06:11

wszydlak force-pushed the wszydlak-patch-1 branch from fffa970 to 3c93715 Compare November 16, 2024 06:11

kirkwaiblinger approved these changes Nov 16, 2024

View reviewed changes

bradzacher merged commit ab83198 into typescript-eslint:main Nov 16, 2024
61 of 62 checks passed

github-actions bot locked as resolved and limited conversation to collaborators Nov 26, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(eslint-plugin): report deprecations used in default export #10330

fix(eslint-plugin): report deprecations used in default export #10330

wszydlak commented Nov 14, 2024

typescript-eslint bot commented Nov 14, 2024

netlify bot commented Nov 14, 2024 •

edited

Loading

nx-cloud bot commented Nov 14, 2024 •

edited

Loading

JoshuaKGoldberg left a comment

codecov bot commented Nov 14, 2024 •

edited

Loading

JoshuaKGoldberg left a comment

JoshuaKGoldberg left a comment

kirkwaiblinger Nov 15, 2024

wszydlak Nov 16, 2024

kirkwaiblinger left a comment

@@ @@ -100,6 +100,16 @@ ruleTester.run('no-deprecated', rule, { @@
                     a('b');
                   `,
+                  `

fix(eslint-plugin): report deprecations used in default export #10330

fix(eslint-plugin): report deprecations used in default export #10330

Conversation

wszydlak commented Nov 14, 2024

PR Checklist

Overview

typescript-eslint bot commented Nov 14, 2024

netlify bot commented Nov 14, 2024 • edited Loading

✅ Deploy Preview for typescript-eslint ready!

nx-cloud bot commented Nov 14, 2024 • edited Loading

☁️ Nx Cloud Report

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

codecov bot commented Nov 14, 2024 • edited Loading

Codecov Report

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

kirkwaiblinger Nov 15, 2024

Choose a reason for hiding this comment

wszydlak Nov 16, 2024

Choose a reason for hiding this comment

kirkwaiblinger left a comment

Choose a reason for hiding this comment

netlify bot commented Nov 14, 2024 •

edited

Loading

nx-cloud bot commented Nov 14, 2024 •

edited

Loading

codecov bot commented Nov 14, 2024 •

edited

Loading