Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: [no-floating-promises] Disable checkThenables by default in v8 #9508

Closed
4 tasks done
JoshuaKGoldberg opened this issue Jul 6, 2024 · 1 comment
Closed
4 tasks done
Assignees
Labels
enhancement: plugin rule option New rule option for an existing eslint-plugin rule locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin team assigned A member of the typescript-eslint team should work on this.
Milestone

Comments

@JoshuaKGoldberg
Copy link
Member

Before You File a Proposal Please Confirm You Have Done The Following...

My proposal is suitable for this project

  • I believe my proposal would be useful to the broader TypeScript community (meaning it is not a niche proposal).

Link to the rule's documentation

https://v8--typescript-eslint.netlify.app/rules/no-floating-promises

Description

Following #8433 -> #9263: we'd resolved to add a new checkThenables option to the no-floating-promises rule. It's enabled by default in v7 to avoid a breaking change. But for v8 we'd like to disable it by default.

Fail

/* @typescript-eslint/no-floating-promises: ["error", { "checkThenables": true }] */

interface MyThenable extends PromiseLike<string> {}

declare function createMyThenable(): Promise<string>;

createMyThenable();

Pass

interface MyThenable extends PromiseLike<string> {}

declare function createMyThenable(): MyThenable;

createMyThenable();

Additional Info

💖

@JoshuaKGoldberg JoshuaKGoldberg added package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin enhancement: plugin rule option New rule option for an existing eslint-plugin rule team assigned A member of the typescript-eslint team should work on this. labels Jul 6, 2024
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Jul 6, 2024
@JoshuaKGoldberg JoshuaKGoldberg added this to the 8.0.0 milestone Jul 6, 2024
Copy link

Closed by #9559.

@github-actions github-actions bot added the locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. label Jul 23, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement: plugin rule option New rule option for an existing eslint-plugin rule locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin team assigned A member of the typescript-eslint team should work on this.
Projects
None yet
1 participant