Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename sort-type-union-intersection-members to sort-type-constituents #5841

Closed
JoshuaKGoldberg opened this issue Oct 17, 2022 · 0 comments · Fixed by #5879
Closed

Rename sort-type-union-intersection-members to sort-type-constituents #5841

JoshuaKGoldberg opened this issue Oct 17, 2022 · 0 comments · Fixed by #5879
Labels
accepting prs Go ahead, send a pull request that resolves this issue breaking change This change will require a new major version to be released package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin

Comments

@JoshuaKGoldberg
Copy link
Member

Overview

Branching out from #5728 (comment): the correct term for one of the types in a | union or & intersection is a constituent. Or at least I think it is. Someone should correct me ASAP if not.

https://typescript-eslint.io/rules/no-redundant-type-constituents/ calls them constituents. I think we should rename sort-type-union-intersection-members to sort-type-constituents to standardize & simplify the name.
@JoshuaKGoldberg JoshuaKGoldberg added package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin triage Waiting for team members to take a look breaking change This change will require a new major version to be released labels Oct 17, 2022
@bradzacher bradzacher added accepting prs Go ahead, send a pull request that resolves this issue and removed triage Waiting for team members to take a look labels Oct 24, 2022
@JoshuaKGoldberg JoshuaKGoldberg changed the title Consider renaming sort-type-union-intersection-members to sort-type-constituents Rename sort-type-union-intersection-members to sort-type-constituents Oct 25, 2022
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Oct 25, 2022
Merged
3 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepting prs Go ahead, send a pull request that resolves this issue breaking change This change will require a new major version to be released package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin
Projects
None yet
Milestone
No milestone
2 participants
@JoshuaKGoldberg @bradzacher