-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Encoder derivation for collection incompatible implementations for interpreted serde e.g. Seq instead of Vector #804
Comments
chris-twiner
added a commit
to chris-twiner/frameless
that referenced
this issue
Mar 20, 2024
This test proves it's eval only, swap forceInterpreted to forceCodeGen and it'll run. |
chris-twiner
added a commit
to chris-twiner/frameless
that referenced
this issue
Mar 20, 2024
(cherry picked from commit caed43956187a52f1a37d8192b70bd9ecf297a1f)
chris-twiner
added a commit
to chris-twiner/frameless
that referenced
this issue
Mar 20, 2024
chris-twiner
added a commit
to chris-twiner/frameless
that referenced
this issue
Mar 20, 2024
chris-twiner
changed the title
Encoder derivation for collection incompatible implementations e.g. Seq instead of Vector
Encoder derivation for collection incompatible implementations for interpreted serde e.g. Seq instead of Vector
Mar 20, 2024
chris-twiner
added a commit
to chris-twiner/frameless
that referenced
this issue
Mar 20, 2024
chris-twiner
added a commit
to chris-twiner/frameless
that referenced
this issue
Mar 20, 2024
…shtrieset no longer there on 2.13
chris-twiner
added a commit
to chris-twiner/frameless
that referenced
this issue
Mar 20, 2024
…shtrieset no longer there on 2.13
chris-twiner
added a commit
to chris-twiner/frameless
that referenced
this issue
Mar 20, 2024
…13 forced changes, compilation issue with toSeq():GenSeq
chris-twiner
added a commit
to chris-twiner/frameless
that referenced
this issue
Mar 20, 2024
…13 forced changes, compilation issue with toSeq():GenSeq
chris-twiner
added a commit
to chris-twiner/frameless
that referenced
this issue
Mar 20, 2024
…13 forced changes, compilation issue with toSeq():GenSeq
chris-twiner
added a commit
to chris-twiner/frameless
that referenced
this issue
Mar 20, 2024
…13 forced changes, compilation issue with toSeq():GenSeq
chris-twiner
added a commit
to chris-twiner/frameless
that referenced
this issue
Mar 20, 2024
…13 forced changes, compilation issue with toSeq():GenSeq
chris-twiner
added a commit
to chris-twiner/frameless
that referenced
this issue
Mar 20, 2024
chris-twiner
added a commit
to chris-twiner/frameless
that referenced
this issue
Mar 21, 2024
chris-twiner
added a commit
to chris-twiner/frameless
that referenced
this issue
Mar 21, 2024
chris-twiner
added a commit
to chris-twiner/frameless
that referenced
this issue
Mar 21, 2024
chris-twiner
added a commit
to chris-twiner/frameless
that referenced
this issue
Mar 21, 2024
chris-twiner
added a commit
to chris-twiner/frameless
that referenced
this issue
Mar 21, 2024
chris-twiner
added a commit
to chris-twiner/frameless
that referenced
this issue
Mar 21, 2024
chris-twiner
added a commit
to chris-twiner/frameless
that referenced
this issue
Mar 21, 2024
This was referenced Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Collection encoder uses MapObjects, this does not have special logic for Vector and will return a Seq that can be a different class.
Scope is serialisation with interpretation (many use-cases will do codegen), compilation of MapObjects is correct and uses builders. Eval of MapObjects with NewInstance fails as NewInstance will look for a Seq constructor parameter but only a Vector parameter exists.
In fixing #803 the use of Vector in UdfTests."one argument udf" failed as:
which is true. The Stream$Cons is created by MapObjects:
There are a number of these potential issues with all similar Seq derived types (Set derived as well).
The inbuilt ScalaReflection createIterableEncoder also correctly uses the appropriate builder.
The text was updated successfully, but these errors were encountered: