Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

# 12269 - bump codecov & codspeed #12270

Merged
merged 1 commit into from
Jul 28, 2024
Merged

# 12269 - bump codecov & codspeed #12270

merged 1 commit into from
Jul 28, 2024

Conversation

eevelweezel
Copy link
Contributor

Fixes #12269

Bump GH actions version for CodSpeed & CodeCov.

Apologies for missing this in #12259, but I only checked the versions I changed.

Copy link

codspeed-hq bot commented Jul 28, 2024

CodSpeed Performance Report

Merging #12270 will not alter performance

Comparing eevelweezel:12269 (6beab96) with trunk (20cc88c)

Summary

✅ 16 untouched benchmarks

@eevelweezel
Copy link
Contributor Author

eevelweezel commented Jul 28, 2024

@twm I've updated both the codecov & codspeed actions, but I believe https://github.com/twisted/twisted/settings/actions will need to be updated to allow CodSpeedHQ/action@v3. I don't have access to make this change.

codspeedhq/action@v3 is not allowed to be used in twisted/twisted. Actions in this workflow must be: within a repository owned by twisted, created by GitHub, or matching the following: mxschmitt/action-tmate@*, codecov/codecov-action@*, pypa/gh-action-pypi-publish@*, CodSpeedHQ/action@v2.

@glyph
Copy link
Member

glyph commented Jul 28, 2024

@twm I've updated both the codecov & codspeed actions, but I believe https://github.com/twisted/twisted/settings/actions will need to be updated to allow CodSpeedHQ/action@v3. I don't have access to make this change.

codspeedhq/action@v3 is not allowed to be used in twisted/twisted. Actions in this workflow must be: within a repository owned by twisted, created by GitHub, or matching the following: mxschmitt/action-tmate@*, codecov/codecov-action@*, pypa/gh-action-pypi-publish@*, CodSpeedHQ/action@v2.

I added a CodSpeedHQ/action@v3, line in the relevant text box and saved it. Let me know if you need anything else.

@eevelweezel
Copy link
Contributor Author

@glyph can you re-run the CI? I don't think I can, without pushing a commit.

@twm
Copy link
Contributor

twm commented Jul 28, 2024

@eevelweezel Unfortunately I don't seem to be able to trigger the workflow in the UI as the branch is on your fork.

@eevelweezel
Copy link
Contributor Author

please-review

@chevah-robot chevah-robot requested a review from a team July 28, 2024 03:29
Copy link
Contributor

@twm twm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you @eevelweezel!

The coverage decrease that codecov is reporting is just flakiness. If you click through there's no change. Looks like it fixed itself.

I'll go ahead and merge!

@twm twm merged commit 78649d4 into twisted:trunk Jul 28, 2024
27 checks passed
@adiroiban
Copy link
Member

The codecov.io coverage might not be flakiness ... but just delayed reporting.

Codecov has no notion of build-set... or GitHub Action workflow.

Each report is uploaded as a separate job... and as soon as the first reports are recevied a prelimiary status is published... as more reports are received the status is updated.

@twm what we can do for codecov... is that instead of uploading to codecov.io the coverage.xml file for each build, we send the compined coverage from our new dedicated coverage summary job.

In this way, codecov.io receives a single and final report .

In this case, as soon as codecov.io is publishing a commit status, it should be final.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update CodeCov and CodSpeed Github actions
5 participants