-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
# 12269 - bump codecov & codspeed #12270
Conversation
CodSpeed Performance ReportMerging #12270 will not alter performanceComparing Summary
|
@twm I've updated both the codecov & codspeed actions, but I believe https://github.com/twisted/twisted/settings/actions will need to be updated to allow CodSpeedHQ/action@v3. I don't have access to make this change.
|
I added a |
@glyph can you re-run the CI? I don't think I can, without pushing a commit. |
@eevelweezel Unfortunately I don't seem to be able to trigger the workflow in the UI as the branch is on your fork. |
please-review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you @eevelweezel!
The coverage decrease that codecov is reporting is just flakiness. If you click through there's no change. Looks like it fixed itself.
I'll go ahead and merge!
The codecov.io coverage might not be flakiness ... but just delayed reporting. Codecov has no notion of build-set... or GitHub Action workflow. Each report is uploaded as a separate job... and as soon as the first reports are recevied a prelimiary status is published... as more reports are received the status is updated. @twm what we can do for codecov... is that instead of uploading to codecov.io the In this way, codecov.io receives a single and final report . In this case, as soon as codecov.io is publishing a commit status, it should be final. |
Fixes #12269
Bump GH actions version for CodSpeed & CodeCov.
Apologies for missing this in #12259, but I only checked the versions I changed.