Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored all single record actions #9045

Merged
merged 22 commits into from
Dec 16, 2024
Merged

Refactored all single record actions #9045

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
e6e226f
use contextual actions in record show page
bosiraphael Dec 11, 2024
137f641
create WorkflowSingleRecordActionsConfig
bosiraphael Dec 11, 2024
75da1b3
refactoring in progress
bosiraphael Dec 12, 2024
eb023e7
refactor workflow version actions
bosiraphael Dec 12, 2024
273ed44
Merge branch 'main' into 8973-refactor-recordshowpageworkflowheader-t…
bosiraphael Dec 12, 2024
b1a4e05
unset command menu context store when closing it
bosiraphael Dec 12, 2024
c43773f
refactor single record actions
bosiraphael Dec 12, 2024
75a2021
remove tests
bosiraphael Dec 12, 2024
51c61c5
fix
bosiraphael Dec 12, 2024
86654e5
fixes
bosiraphael Dec 13, 2024
daa4711
rename hooks
bosiraphael Dec 13, 2024
1f8b0a0
create util to get the action config
bosiraphael Dec 13, 2024
aedab25
create test for useAddToFavoritesSingleRecordAction
bosiraphael Dec 13, 2024
d809f39
test onclick
bosiraphael Dec 13, 2024
a4813be
create test for useRemoveFromFavoritesSingleRecordAction
bosiraphael Dec 13, 2024
fc31cef
add test for useDeleteSingleRecordAction
bosiraphael Dec 13, 2024
cf1b1d1
fixes
bosiraphael Dec 13, 2024
90db2c9
create test for useActivateDraftWorkflowSingleRecordAction
bosiraphael Dec 16, 2024
618a382
create test for useActivateLastPublishedVersionWorkflowSingleRecordAc…
bosiraphael Dec 16, 2024
901cf42
create test for useDeactivateWorkflowSingleRecordAction
bosiraphael Dec 16, 2024
c5340b9
create test for useDiscardDraftWorkflowSingleRecordAction
bosiraphael Dec 16, 2024
c251510
Merge branch 'main' into 8973-refactor-recordshowpageworkflowheader-t…
bosiraphael Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix
  • Loading branch information
@bosiraphael
bosiraphael committed Dec 12, 2024
commit 51c61c5eac9a08b87bbb9fef013fe4f6c9fe6dff
3 changes: 2 additions & 1 deletion ...on-menu/actions/record-actions/single-record/hooks/useAddToFavoritesSingleRecordAction.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,12 @@ export const useAddToFavoritesSingleRecordAction: SingleRecordActionHookWithObje

const shouldBeRegistered =
isDefined(objectMetadataItem) &&
isDefined(selectedRecord) &&
!objectMetadataItem.isRemote &&
!isFavorite;

const onClick = () => {
if (!isDefined(selectedRecord)) {
if (!shouldBeRegistered) {
return;
}

Expand Down
Loading