Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date filter improvements (#5917) #7196

Merged
Merged
Changes from 1 commit
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
5635983
Add new operands, draft relative date picker header
ad-elias Sep 15, 2024
80c608c
Generate query filters for new view filter operands
ad-elias Sep 16, 2024
0953394
Disable relative date picker calendar clicking
ad-elias Sep 16, 2024
fa1cae9
Change date filter value to JSON
ad-elias Sep 17, 2024
74cd021
Resolve variable filter values, pick relative dates
ad-elias Sep 19, 2024
e0d2701
Merge branch 'main' into feat/date-filter-improvements-5917
ad-elias Sep 19, 2024
d2bc804
Temporarily disable all new date operands, fix view filter workspace …
ad-elias Sep 20, 2024
146df05
Past and future date filters work
ad-elias Sep 20, 2024
f5a1b14
Add isToday filter operand to date: and query does not work, otherwis…
ad-elias Sep 20, 2024
7462f63
Fix checkForDeletedAtFilter this binding
ad-elias Sep 20, 2024
09bf125
Simplify filter value resolution
ad-elias Sep 21, 2024
7855ba6
Add 'is' filter operand to date. And query does not work.
ad-elias Sep 21, 2024
031ea27
Rename 'greater than' and 'less than' date filters
ad-elias Sep 21, 2024
5c5b5f0
Enable relative date filtering. And query does not work, date range h…
ad-elias Sep 22, 2024
7e1eafe
Highlight selected relative dates
ad-elias Sep 23, 2024
577f83d
Merge branch 'main' into feat/date-filter-improvements-5917
ad-elias Sep 23, 2024
10f4f87
Remove unused code
ad-elias Sep 23, 2024
3b9c891
Fix broken date selection
ad-elias Sep 23, 2024
3fc73c5
Refactor
ad-elias Sep 23, 2024
b8dc5e6
Remove comments
ad-elias Sep 24, 2024
20d652f
Improve naming
ad-elias Sep 24, 2024
c2dcef5
Default to ViewFilterValueType.STATIC
ad-elias Sep 24, 2024
26d03e7
Improve readability
ad-elias Sep 24, 2024
82c7537
Disable relative date picker header dropdown blur
ad-elias Sep 24, 2024
80adc22
List configurable view filter operands
ad-elias Sep 24, 2024
75f9ddd
Refactor & make 'valueType' required in frontend
ad-elias Sep 24, 2024
6a4789f
Reset value on value type change
ad-elias Sep 25, 2024
0548fc6
Fix number & currency filter operands
ad-elias Sep 26, 2024
c78fdb0
Remove default relative date unit
ad-elias Sep 26, 2024
f915833
Fix date operands test
ad-elias Sep 26, 2024
ef7eba1
Remove filter valueType
ad-elias Sep 27, 2024
36eccfd
Fix date filter default values
ad-elias Sep 27, 2024
9ec65de
Initialize filter value on operand change to immediately show results…
ad-elias Sep 27, 2024
f8d767b
Merge
FelixMalfait Sep 27, 2024
8ad4774
Fix merge
FelixMalfait Sep 27, 2024
34f8e9b
Is this used?
FelixMalfait Sep 27, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix checkForDeletedAtFilter this binding
  • Loading branch information
ad-elias committed Sep 20, 2024
commit 7462f63164b46980972a1522f2490afa40f2547e
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,9 @@ export class GraphqlQueryParser {
};
}

private checkForDeletedAtFilter(
private checkForDeletedAtFilter = (
filter: FindOptionsWhere<ObjectLiteral> | FindOptionsWhere<ObjectLiteral>[],
): boolean {
): boolean => {
if (Array.isArray(filter)) {
return filter.some(this.checkForDeletedAtFilter);
}
Expand All @@ -72,7 +72,7 @@ export class GraphqlQueryParser {
}

return false;
}
};

parseOrder(
orderBy: RecordOrderBy,
Expand Down