Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6658 workflows add a first twenty piece email sender #6965

Merged
merged 24 commits into from
Sep 12, 2024
+1,144 −1,038
Merged

6658 workflows add a first twenty piece email sender #6965

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
6339a4e
Add system action executor
martmull Sep 9, 2024
e484c60
Add send email step
martmull Sep 9, 2024
4528242
Remove logo from workflow email
martmull Sep 10, 2024
cb33021
Sanitize html
martmull Sep 10, 2024
2e44781
Fix typing
martmull Sep 10, 2024
4978270
Remove front check
martmull Sep 10, 2024
52ac80d
Fix missing data in deleted event
martmull Sep 10, 2024
d030c01
Validate email
martmull Sep 10, 2024
5b50565
Use templating
martmull Sep 10, 2024
77e78a8
Remove useless factory
martmull Sep 11, 2024
2f4a6de
Remove useless changes
martmull Sep 11, 2024
fa03414
Code review return: fix factory naming
martmull Sep 11, 2024
8fca876
Code review return: separate types
martmull Sep 11, 2024
4bcb226
Code review return: update naming
martmull Sep 11, 2024
f99d805
Code review return: reorganize folders
martmull Sep 11, 2024
98fdcfb
Code review return: split workflow/common
martmull Sep 11, 2024
3e74a5d
Simplify folder tree
martmull Sep 11, 2024
5726382
Reorganize workflow-runner
martmull Sep 11, 2024
611b4ca
Reorganize workflow-status
martmull Sep 11, 2024
c8b0b4a
Rename services folders
martmull Sep 11, 2024
b3bde02
Simplify workflow/common
martmull Sep 11, 2024
6ecd69d
Merge integration and core_modules
martmull Sep 11, 2024
d0d9376
Fix lint
martmull Sep 11, 2024
7afe454
WIP: move workflow actions to dedicated modules
martmull Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Code review return: fix factory naming
  • Loading branch information
@martmull
martmull committed Sep 11, 2024
commit fa03414a7d07b62f193769dbd8efb9da339a9d18
2 changes: 1 addition & 1 deletion ...factories/code-action-executor.factory.ts → .../factories/code.workflow-step-executor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import {
} from 'src/modules/workflow/workflow-step-executor/workflow-step-executor.exception';

@Injectable()
export class CodeActionExecutorFactory {
export class CodeWorkflowStepExecutor {
constructor(
private readonly serverlessFunctionService: ServerlessFunctionService,
private readonly scopedWorkspaceContextFactory: ScopedWorkspaceContextFactory,
Expand Down
4 changes: 2 additions & 2 deletions ...ies/send-email-action-executor.factory.ts → ...ries/send-email.workflow-step-executor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ import { EnvironmentService } from 'src/engine/integrations/environment/environm
import { EmailService } from 'src/engine/integrations/email/email.service';

@Injectable()
export class SendEmailActionExecutorFactory {
private readonly logger = new Logger(SendEmailActionExecutorFactory.name);
export class SendEmailWorkflowStepExecutor {
private readonly logger = new Logger(SendEmailWorkflowStepExecutor.name);
constructor(
private readonly environmentService: EnvironmentService,
private readonly emailService: EmailService,
Expand Down
12 changes: 6 additions & 6 deletions ...enty-server/src/modules/workflow/workflow-step-executor/workflow-step-executor.factory.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,22 +6,22 @@ import {
WorkflowStepExecutorExceptionCode,
} from 'src/modules/workflow/workflow-step-executor/workflow-step-executor.exception';
import { WorkflowStepExecutor } from 'src/modules/workflow/workflow-step-executor/workflow-step-executor.interface';
import { CodeActionExecutorFactory } from 'src/modules/workflow/workflow-step-executor/factories/code-action-executor.factory';
import { SendEmailActionExecutorFactory } from 'src/modules/workflow/workflow-step-executor/factories/send-email-action-executor.factory';
import { CodeWorkflowStepExecutor } from 'src/modules/workflow/workflow-step-executor/factories/code.workflow-step-executor';
import { SendEmailWorkflowStepExecutor } from 'src/modules/workflow/workflow-step-executor/factories/send-email.workflow-step-executor';

@Injectable()
export class WorkflowStepExecutorFactory {
constructor(
private readonly codeActionExecutor: CodeActionExecutorFactory,
private readonly sendEmailActionExecutor: SendEmailActionExecutorFactory,
private readonly codeWorkflowStepExecutor: CodeWorkflowStepExecutor,
private readonly sendEmailWorkflowStepExecutor: SendEmailWorkflowStepExecutor,
) {}

get(stepType: WorkflowStepType): WorkflowStepExecutor {
switch (stepType) {
case WorkflowStepType.CODE_ACTION:
return this.codeActionExecutor;
return this.codeWorkflowStepExecutor;
case WorkflowStepType.SEND_EMAIL_ACTION:
return this.sendEmailActionExecutor;
return this.sendEmailWorkflowStepExecutor;
default:
throw new WorkflowStepExecutorException(
`Workflow step executor not found for step type '${stepType}'`,
Expand Down
8 changes: 4 additions & 4 deletions ...wenty-server/src/modules/workflow/workflow-step-executor/workflow-step-executor.module.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,15 @@ import { Module } from '@nestjs/common';
import { ServerlessFunctionModule } from 'src/engine/metadata-modules/serverless-function/serverless-function.module';
import { ScopedWorkspaceContextFactory } from 'src/engine/twenty-orm/factories/scoped-workspace-context.factory';
import { WorkflowStepExecutorFactory } from 'src/modules/workflow/workflow-step-executor/workflow-step-executor.factory';
import { CodeActionExecutorFactory } from 'src/modules/workflow/workflow-step-executor/factories/code-action-executor.factory';
import { SendEmailActionExecutorFactory } from 'src/modules/workflow/workflow-step-executor/factories/send-email-action-executor.factory';
import { CodeWorkflowStepExecutor } from 'src/modules/workflow/workflow-step-executor/factories/code.workflow-step-executor';
import { SendEmailWorkflowStepExecutor } from 'src/modules/workflow/workflow-step-executor/factories/send-email.workflow-step-executor';

@Module({
imports: [ServerlessFunctionModule],
providers: [
WorkflowStepExecutorFactory,
CodeActionExecutorFactory,
SendEmailActionExecutorFactory,
CodeWorkflowStepExecutor,
SendEmailWorkflowStepExecutor,
ScopedWorkspaceContextFactory,
],
exports: [WorkflowStepExecutorFactory],
Expand Down
Loading