Code review return: update naming

twentyhq · martmull · Sep 12, 2024 · Sep 9, 2024 · Sep 9, 2024 · Sep 10, 2024
commit 4bcb22652398facf2b876cdeee2af7e513db3525
diff --git a/packages/twenty-server/src/modules/workflow/common/types/workflow-step-result.type.ts b/packages/twenty-server/src/modules/workflow/common/types/workflow-step-result.type.ts
@@ -5,6 +5,6 @@ type WorkflowError = {
 };
 
 export type WorkflowStepResult = {
-  data?: object;
+  result?: object;
   error?: WorkflowError;
 };
diff --git a/...enty-server/src/modules/workflow/workflow-executor/workflow-executor.workspace-service.ts b/...enty-server/src/modules/workflow/workflow-executor/workflow-executor.workspace-service.ts
@@ -10,7 +10,7 @@ import { WorkflowStepExecutorFactory } from 'src/modules/workflow/workflow-step-
 const MAX_RETRIES_ON_FAILURE = 3;
 
 export type WorkflowExecutionOutput = {
-  data?: object;
+  result?: object;
   error?: object;
 };
 
@@ -33,7 +33,7 @@ export class WorkflowExecutorWorkspaceService {
   }): Promise<WorkflowExecutionOutput> {
     if (currentStepIndex >= steps.length) {
       return {
-        data: payload,
+        result: payload,
       };
     }
 
@@ -48,11 +48,11 @@ export class WorkflowExecutorWorkspaceService {
       payload,
     });
 
-    if (result.data) {
+    if (result.result) {
       return await this.execute({
         currentStepIndex: currentStepIndex + 1,
         steps,
-        payload: result.data,
+        payload: result.result,
       });
     }
 

diff --git a/...rver/src/modules/workflow/workflow-step-executor/factories/code.workflow-step-executor.ts b/...rver/src/modules/workflow/workflow-step-executor/factories/code.workflow-step-executor.ts
@@ -43,6 +43,6 @@ export class CodeWorkflowStepExecutor {
       return { error: result.error };
     }
 
-    return { data: result.data || {} };
+    return { result: result.data || {} };
   }
 }
diff --git a/...rc/modules/workflow/workflow-step-executor/factories/send-email.workflow-step-executor.ts b/...rc/modules/workflow/workflow-step-executor/factories/send-email.workflow-step-executor.ts
@@ -38,7 +38,7 @@ export class SendEmailWorkflowStepExecutor {
       if (!result.success) {
         this.logger.warn(`Email '${payload.email}' invalid`);
 
-        return { data: { success: false } };
+        return { result: { success: false } };
       }
 
       const mainText = Handlebars.compile(step.settings.template)(payload);
@@ -69,7 +69,7 @@ export class SendEmailWorkflowStepExecutor {
         html,
       });
 
-      return { data: { success: true } };
+      return { result: { success: true } };
     } catch (error) {
       return { error };
     }