removing version from docker-compose file #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awlawl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current stable release, the code executes docker-compose locally on the host to normalize docker-compose.yml files before use. With docker-compose version 2+, this output doesn't include the "version" attribute in the yaml. The Fargate CLI expects this value and uses as a way to verify if the output is parsed correctly.
The future specifications for docker-compose use the new Compose Specification. This doesn't include a version attribute anymore. For this reason, I've removed the code that checks for it and removed the attribute all together.
I know this will require some additional testing with teams that are using docker-compose and task based workflows.