Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add table aws_scheduler_schedule Closes #2304 #2359

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add table aws_scheduler_schedule Closes #2304 #2359

wants to merge 3 commits into from

Conversation

ParthaI
Copy link
Contributor

@ParthaI ParthaI commented Dec 17, 2024

Integration test logs

Logs 
N/A

Example query results

Results 
> select * from aws_scheduler_schedule where state = 'ENABLED'
+----------+---------------------------------------------------------------------+---------+-------------+-------------------------+------------------------------+---------------------------+---------------------------+---------------------------+---------------------->
| name     | arn                                                                 | state   | description | schedule_expression     | schedule_expression_timezone | creation_date             | last_modification_date    | start_date                | end_date             >
+----------+---------------------------------------------------------------------+---------+-------------+-------------------------+------------------------------+---------------------------+---------------------------+---------------------------+---------------------->
| test6333 | arn:aws:scheduler:us-east-2:xxxxxxxxxxxx:schedule/test-new/test6333 | ENABLED | sp          | rate(12 minutes)        | Asia/Calcutta                | 2024-12-17T17:32:35+05:30 | 2024-12-17T17:37:02+05:30 | 2024-12-18T12:22:00+05:30 | 2024-12-28T12:22:00+0>
| test53   | arn:aws:scheduler:us-east-2:xxxxxxxxxxxx:schedule/default/test53    | ENABLED | testing     | at(2024-12-17T12:30:00) | Asia/Calcutta                | 2024-12-17T17:28:45+05:30 | 2024-12-17T17:28:45+05:30 | <null>                    | <null>               >
+----------+---------------------------------------------------------------------+---------+-------------+-------------------------+------------------------------+---------------------------+---------------------------+---------------------------+---------------------->
> select * from aws_scheduler_schedule where group_name = 'test'
+------+-----+-------+-------------+---------------------+------------------------------+---------------+------------------------+------------+----------+------------+-------------+-------------------------+----------------------+--------+-------+------+-----------+--->
| name | arn | state | description | schedule_expression | schedule_expression_timezone | creation_date | last_modification_date | start_date | end_date | group_name | kms_key_arn | action_after_completion | flexible_time_window | target | title | akas | partition | re>
+------+-----+-------+-------------+---------------------+------------------------------+---------------+------------------------+------------+----------+------------+-------------+-------------------------+----------------------+--------+-------+------+-----------+--->
+------+-----+-------+-------------+---------------------+------------------------------+---------------+------------------------+------------+----------+------------+-------------+-------------------------+----------------------+--------+-------+------+-----------+--->
> select * from aws_scheduler_schedule where group_name = 'default' and name = 'test53'
+--------+------------------------------------------------------------------+---------+-------------+-------------------------+------------------------------+---------------------------+---------------------------+------------+----------+------------+-------------+---->
| name   | arn                                                              | state   | description | schedule_expression     | schedule_expression_timezone | creation_date             | last_modification_date    | start_date | end_date | group_name | kms_key_arn | act>
+--------+------------------------------------------------------------------+---------+-------------+-------------------------+------------------------------+---------------------------+---------------------------+------------+----------+------------+-------------+---->
| test53 | arn:aws:scheduler:us-east-2:xxxxxxxxxxxx:schedule/default/test53 | ENABLED | testing     | at(2024-12-17T12:30:00) | Asia/Calcutta                | 2024-12-17T17:28:45+05:30 | 2024-12-17T17:28:45+05:30 | <null>     | <null>   | default    | <null>      | NON>
+--------+------------------------------------------------------------------+---------+-------------+-------------------------+------------------------------+---------------------------+---------------------------+------------+----------+------------+-------------+---->

@ParthaI ParthaI requested a review from misraved December 17, 2024 12:26
@ParthaI ParthaI self-assigned this Dec 17, 2024
@ParthaI ParthaI linked an issue Dec 17, 2024 that may be closed by this pull request
Add table aws_eventbridge_scheduler #2304
Open
misraved
misraved reviewed Dec 17, 2024
View reviewed changes
aws/table_aws_scheduler_schedule.go

func tableAwsSchedulerSchedule(_ context.Context) *plugin.Table {
return &plugin.Table{
Name: "aws_scheduler_schedule",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Name: "aws_scheduler_schedule",
Name: "aws_eventbridge_schedule",

Should we use the above table name?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following the Terraform naming convention, it is aws_scheduler_* (reference: https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/scheduler_schedule).

Do you think we should rename it?

misraved
misraved reviewed Dec 17, 2024
View reviewed changes
docs/tables/aws_scheduler_schedule.md Outdated
name = 'my-schedule';
```

---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
---

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misraved misraved misraved left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@ParthaI ParthaI

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add table aws_eventbridge_scheduler
2 participants
@ParthaI @misraved