From e1f1502c53a71399629db582ebabc630d4cc7049 Mon Sep 17 00:00:00 2001 From: Sential Date: Tue, 1 Oct 2019 20:06:41 +0200 Subject: [PATCH] fix: history items removing shows selection dialog --- package-lock.json | 6 ------ package.json | 1 - src/renderer/views/history/components/HistoryItem/index.tsx | 3 ++- webpack.config.base.js | 5 ----- 4 files changed, 2 insertions(+), 13 deletions(-) diff --git a/package-lock.json b/package-lock.json index 58ebd1510..53856c193 100644 --- a/package-lock.json +++ b/package-lock.json @@ -9500,12 +9500,6 @@ "integrity": "sha512-pISE66AbVkp4fDQ7VHBwRNXzAAKJjw4Vw7nWI/+Q3vuly7SNfgYXvm6i5IgFylHGK5sP/xHAbB7N49OS4gWNyQ==", "dev": true }, - "preact": { - "version": "10.0.0-rc.3", - "resolved": "https://registry.npmjs.org/preact/-/preact-10.0.0-rc.3.tgz", - "integrity": "sha512-IvDc2AGvHJncEtORciLDzpluDF2MsZqf9eo6xHt7HVY4E6OvxZzAePYJtv3siVdEntxmB9NciQpbToT1APqJYQ==", - "dev": true - }, "prebuild-install": { "version": "5.3.1", "resolved": "https://registry.npmjs.org/prebuild-install/-/prebuild-install-5.3.1.tgz", diff --git a/package.json b/package.json index b0d5d200b..33147d822 100644 --- a/package.json +++ b/package.json @@ -81,7 +81,6 @@ "node-fetch": "^2.6.0", "node-vibrant": "^3.2.0-alpha", "node-window-manager": "1.1.0", - "preact": "^10.0.0-rc.3", "prettier": "1.18.2", "pretty-bytes": "5.3.0", "react": "16.10.1", diff --git a/src/renderer/views/history/components/HistoryItem/index.tsx b/src/renderer/views/history/components/HistoryItem/index.tsx index 9efc39656..d07feefe8 100644 --- a/src/renderer/views/history/components/HistoryItem/index.tsx +++ b/src/renderer/views/history/components/HistoryItem/index.tsx @@ -24,7 +24,8 @@ const onTitleClick = (url: string) => (e: React.MouseEvent) => { } }; -const onRemoveClick = (item: IHistoryItem) => () => { +const onRemoveClick = (item: IHistoryItem) => (e: React.MouseEvent) => { + e.stopPropagation(); store.removeItem(item._id); }; diff --git a/webpack.config.base.js b/webpack.config.base.js index 6caec58a6..48bf0037f 100644 --- a/webpack.config.base.js +++ b/webpack.config.base.js @@ -78,11 +78,6 @@ const config = { plugins: [], }; -if (!dev) { - config.resolve.alias.react = 'preact/compat'; - config.resolve.alias['react-dom'] = 'preact/compat'; -} - function getConfig(...cfg) { return merge(config, ...cfg); }