fix: history items removing shows selection dialog

ttuanhung · Oct 1, 2019 · e1f1502 · e1f1502
1 parent 8ba3e0a
commit e1f1502
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 13 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -81,7 +81,6 @@
     "node-fetch": "^2.6.0",
     "node-vibrant": "^3.2.0-alpha",
     "node-window-manager": "1.1.0",
-    "preact": "^10.0.0-rc.3",
     "prettier": "1.18.2",
     "pretty-bytes": "5.3.0",
     "react": "16.10.1",

diff --git a/src/renderer/views/history/components/HistoryItem/index.tsx b/src/renderer/views/history/components/HistoryItem/index.tsx
@@ -24,7 +24,8 @@ const onTitleClick = (url: string) => (e: React.MouseEvent) => {
   }
 };
 
-const onRemoveClick = (item: IHistoryItem) => () => {
+const onRemoveClick = (item: IHistoryItem) => (e: React.MouseEvent) => {
+  e.stopPropagation();
   store.removeItem(item._id);
 };
 

diff --git a/webpack.config.base.js b/webpack.config.base.js
@@ -78,11 +78,6 @@ const config = {
   plugins: [],
 };
 
-if (!dev) {
-  config.resolve.alias.react = 'preact/compat';
-  config.resolve.alias['react-dom'] = 'preact/compat';
-}
-
 function getConfig(...cfg) {
   return merge(config, ...cfg);
 }