feat: focus search box in new tab page

ttuanhung · Oct 1, 2019 · a76e312 · a76e312
1 parent c71ffa8
commit a76e312
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 1 deletion.
diff --git a/src/main/dialogs/dialog.ts b/src/main/dialogs/dialog.ts
@@ -7,6 +7,7 @@ interface IOptions {
   devtools?: boolean;
   bounds?: IRectangle;
   hideTimeout?: number;
+  customHide?: boolean;
 }
 
 interface IRectangle {

diff --git a/src/main/view-manager.ts b/src/main/view-manager.ts
@@ -2,6 +2,7 @@ import { ipcMain } from 'electron';
 import { TOOLBAR_HEIGHT } from '~/constants/design';
 import { View } from './view';
 import { AppWindow } from './windows';
+import { NEWTAB_URL } from '~/constants/tabs';
 
 export class ViewManager {
   public views: View[] = [];
@@ -162,9 +163,12 @@ export class ViewManager {
     this.window.addBrowserView(view);
 
     this.window.menuDialog.hide();
-    this.window.searchDialog.hide();
     this.window.findDialog.hide();
 
+    if (!view.webContents.getURL().startsWith(NEWTAB_URL)) {
+      this.window.searchDialog.hide();
+    }
+
     this.fixBounds();
   }
 

diff --git a/src/main/view.ts b/src/main/view.ts
@@ -67,6 +67,8 @@ export class View extends BrowserView {
     this.webContents.addListener('did-start-navigation', (...args) => {
       this.updateNavigationState();
 
+      this.favicon = '';
+
       this.window.webContents.send(
         `load-commit-${this.webContents.id}`,
         ...args,

diff --git a/src/renderer/views/app/models/tab.ts b/src/renderer/views/app/models/tab.ts
@@ -11,6 +11,7 @@ import {
   TAB_PINNED_WIDTH,
 } from '../constants';
 import { getColorBrightness, callViewMethod } from '~/utils';
+import { NEWTAB_URL } from '~/constants/tabs';
 
 const isColorAcceptable = (color: string) => {
   if (store.theme['tab.allowLightBackground']) {
@@ -300,6 +301,10 @@ export class ITab {
           this.id,
           this.findInfo,
         );
+
+        if (this.url.startsWith(NEWTAB_URL)) {
+          ipcRenderer.send(`search-show-${store.windowId}`);
+        }
       }
 
       requestAnimationFrame(() => {