Fix a few negated conditions.

tschaub · Oct 9, 2018 · 0cb7056 · 0cb7056
1 parent cebebe7
commit 0cb7056
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 15 deletions.
diff --git a/test/deep-base.spec.js b/test/deep-base.spec.js
@@ -49,10 +49,10 @@ describe('deep-base', () => {
 
   it('copies source files relative to the base', done => {
     fs.exists(path.join(repo, 'hello.txt'), exists => {
-      if (!exists) {
-        done(new Error('Failed to find "hello.txt" in repo: ') + repo);
-      } else {
+      if (exists) {
         done();
+      } else {
+        done(new Error('Failed to find "hello.txt" in repo: ') + repo);
       }
     });
   });

diff --git a/test/different-repo.spec.js b/test/different-repo.spec.js
@@ -49,10 +49,10 @@ describe('different-repo', () => {
 
   it('copies source files', done => {
     fs.exists(path.join(repo, 'hello.txt'), exists => {
-      if (!exists) {
-        done(new Error('Failed to find "hello.txt" in repo: ') + repo);
-      } else {
+      if (exists) {
         done();
+      } else {
+        done(new Error('Failed to find "hello.txt" in repo: ') + repo);
       }
     });
   });

diff --git a/test/dotfiles-option.spec.js b/test/dotfiles-option.spec.js
@@ -58,20 +58,20 @@ describe('dotfiles-option', () => {
 
   it('copies files with dots', done => {
     fs.exists(path.join(repo, '.one'), exists => {
-      if (!exists) {
-        done(new Error('Failed to find ".one" in repo: ') + repo);
-      } else {
+      if (exists) {
         done();
+      } else {
+        done(new Error('Failed to find ".one" in repo: ') + repo);
       }
     });
   });
 
   it('copies files in directories with dots', done => {
     fs.exists(path.join(repo, 'foo', '.bar', 'two'), exists => {
-      if (!exists) {
-        done(new Error('Failed to find "foo/.bar/two" in repo: ') + repo);
-      } else {
+      if (exists) {
         done();
+      } else {
+        done(new Error('Failed to find "foo/.bar/two" in repo: ') + repo);
       }
     });
   });

diff --git a/test/helper.js b/test/helper.js
@@ -14,13 +14,13 @@ const tmpDir = 'tmp';
  * @param {function(Error, Process)} done Callback.
  */
 function spawnGrunt(dir, done) {
-  if (!fs.existsSync(path.join(dir, 'Gruntfile.js'))) {
-    done(new Error(`Cannot find Gruntfile.js in dir: ${dir}`));
-  } else {
+  if (fs.existsSync(path.join(dir, 'Gruntfile.js'))) {
     const node = process.argv[0];
     const grunt = process.argv[1]; // assumes grunt drives these tests
     const child = cp.spawn(node, [grunt, '--verbose'], {cwd: dir});
     done(null, child);
+  } else {
+    done(new Error(`Cannot find Gruntfile.js in dir: ${dir}`));
   }
 }