Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tfsec fixes #474

Merged
merged 1 commit into from
Sep 14, 2023
Merged

Tfsec fixes #474

merged 1 commit into from
Sep 14, 2023

Conversation

TylerJang27
Copy link
Collaborator

If tfsec doesn't find any valid terraform files within a certain range, it will scan recursively until it finds them. On Windows, with junctions this ends up cascading into our plugins repo. On other platforms, when running outside of a sandbox, this can also recurse into our test data, one of which is the checkov test data file, which tfsec incorrectly fails to parse (even though it is valid tf).

I've added a flag to not error on parsing errors like this one. It's a bit heavy-handed, but we have other tf linters in order to address issues like this, and it's better than failing outright, particularly for the users out in the world who already have tfsec enabled.

@TylerJang27 TylerJang27 marked this pull request as ready for review September 14, 2023 22:03
@TylerJang27 TylerJang27 requested review from puzzler7 and det September 14, 2023 22:03
@TylerJang27 TylerJang27 merged commit ee0c282 into main Sep 14, 2023
@TylerJang27 TylerJang27 deleted the tyler/tfsec-fixes branch September 14, 2023 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants