Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: kvlil.
This is most likely caused by a git client misconfiguration; please make sure to:

1. check if your git client is configured with an email to sign commits git config --list | grep email
2. If not, set it up using git config --global user.email email@example.com
3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: kvlil.
This is most likely caused by a git client misconfiguration; please make sure to:

1. check if your git client is configured with an email to sign commits git config --list | grep email
2. If not, set it up using git config --global user.email email@example.com
3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

You can squash all commits and use the PR title as the commit message (describes the why, not what).

How did you test this?

For testing, I ran a local Grafan/Keycloak/Trino stack with docker-compose to check that the authorization header is forwarded between Grafana and Trino.

Hi @nineinchnick, thanks for approving and merging this PR!
Do you have an estimate on when these changes might be released?

I just ran the release and submitted v1.0.8 for veification to Grafana.

Hi @nineinchnick,
I have noticed that the last release of the plugin hasn't been published on the official grafana repo. How long does it take for it to be published?

I've got a review comments from Grafana after I submitted the update, and I haven't had time to address them yet. I wish this was done publicly, like a PR review, but that's the current process. Here's the full message I got:

We recommend the following changes:

• Instead of wrapping the instance factory function, instead update your existing function to receive context.Context and propagate this through the code paths instead of using context.Background(). This will ensure you code is more forward compatible with any changes to the SDK that rely on context propagation.
• Please update the README to mention added OAuth forwarding functionality alongside existing auth methods as this will be helpful for users to understand how to make the most out of the plugin.

Some questions:

• Considering this update will now pass the access token raw as a SQL query param, can you confirm that this information is not being logged anywhere? I did confirm that the call to log the dsn will only log forwardAuthorizationHeader=true, but just wanted to confirm with you as well.
• I wanted to check if you found it necessary to pass the OAuth token via context as it should already be available via the headers http.Header argument in the SetQueryArgs function? I mainly just want to confirm you haven't found a bug.

This was anonymous, signed off as "Grafana Team"

Ok, thanks for the update,
How can it be addressed is it an internal process or can we open a PR to fix those reviews?

A PR would be very welcome!

Ok, I will open a PR with the Grafana Team review description and take care of it when I have time this week.
I'm not sure I get all the points and will probably need some clarification (the first review link looks outdated).

Thank you very much! There was only one PR merged after I cut 1.0.8. #274 removed logging of the DSN

I just submitted 1.0.9 for review and responded to all the questions I got for 1.0.8.

Thank you I didn't have time to work on it last week!

Hi @nineinchnick,
Is there any update for the publication of v1.0.9?

No, I need to test and merge #277 before I can submit another update for review.