Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Begin converting match offsets in struct State to u16 #275

Merged
merged 2 commits into from
Jan 3, 2025
Merged

Begin converting match offsets in struct State to u16 #275

merged 2 commits into from
Jan 3, 2025

Conversation

brian-pane
Copy link

This is the first step of a refactoring to use smaller fields where possible in struct State for better cache locality.

This patch uses the Pos type from longest_match.rs to represent positions in the window.

My benchmark testing shows no change in performance compared to the current main.

folkertdev
folkertdev approved these changes Jan 3, 2025
View reviewed changes
Copy link
Collaborator

@folkertdev folkertdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me there appear to be some minor regressions in instruction count, but that's not something I'm worried about.

@folkertdev folkertdev merged commit b3ec5d9 into trifectatechfoundation:main Jan 3, 2025
20 checks passed
@brian-pane brian-pane deleted the window-size branch January 4, 2025 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@folkertdev folkertdev folkertdev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brian-pane @folkertdev @brianpane