Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies #807

Merged
merged 7 commits into from
Jul 24, 2018
Merged

Update dependencies #807

merged 7 commits into from
Jul 24, 2018

Conversation

jim
Copy link
Contributor

@jim jim commented Jul 24, 2018 •
edited
Loading

Description

This PR updates the Go dependencies, yarn dependencies, and precommit for the project. We had originally reverted these updates as gas changing its name broke a bunch of things.

Reviewer Notes

@tinyels Is working on addressing the failing e2e tests caused by changes to the select library we're using.

@jim jim changed the title Update server deps and precommit. WIP Update server deps and precommit. Jul 24, 2018
@jim jim changed the title WIP Update server deps and precommit. Update dependencies Jul 24, 2018
tinyels
tinyels approved these changes Jul 24, 2018
View reviewed changes
Copy link
Contributor

@tinyels tinyels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jim jim merged commit 140c4ec into master Jul 24, 2018
@jim jim deleted the update-server-deps-and-precommit branch July 24, 2018 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tinyels tinyels tinyels approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jim @tinyels @akostibas