Fix: dynamic router creation #11234
Draft
Fix: dynamic router creation #11234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… empty (`""`) Should fix traefik#5576
N0tExisting
force-pushed
the
fix/dynamic-router-creation
branch
from
244aa77 to
868ab62
Compare
|
hi dude, FYI in my config with latest version this is working well -> defaultRule: ""
|
|
Hi @N0tExisting, Thanks for this contribution! We are wondering whether it should be put out of draft and be reviewed. Are you still iterating on it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Stop routers from being created automatically if the
defaultRuleis empty (""), which should fix #5576Motivation
It was bothering me, that the issue hasn't been fixed after this long.
More
Additional Notes