-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add console parameter to rich wrapper #1282
Conversation
Sourcery Code Quality Report❌ Merging this PR will decrease code quality in the affected files by 0.65%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
@casperdcl can you move this forward? |
@casperdcl can you include this in the new version? |
Ah sorry for the delay :) |
@casperdcl can you include this in next release please? |
thanks for pinging and sorry for the delay! How about #1311 for more generic compatibility? i.e. |
I don't understand #1311 changes, also seems to be titled as 4.63.2 release notes, also console is not boolean, but an instance created elsewhere. you can see the usage of this PR with the PR referred in PR body:
more particularly just this commit: |
Right so from next release, you could replace Taxel/PlexTraktSync@
|
Uh ok. either way is fine probably. |
Fixes Textualize/rich#1766
See also discussion:
Needed by: