Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VS Code now support ipywidgets #1213

Closed
4 of 6 tasks
gordonwatts opened this issue Jul 29, 2021 · 5 comments · Fixed by #1309
Closed
4 of 6 tasks

VS Code now support ipywidgets #1213

gordonwatts opened this issue Jul 29, 2021 · 5 comments · Fixed by #1309
Assignees
@gordonwatts
Labels
p3-enhancement 🔥 Much new such feature submodule-notebook 📓 Much web such IDE

Comments

@gordonwatts
Copy link

  • I have marked all applicable categories:
    • documentation request (i.e. "X is missing from the documentation." If instead I want to ask "how to use X?" I understand [StackOverflow#tqdm] is more appropriate)
    • new feature request
  • I have visited the [source website], and in particular
    read the [known issues]
  • I have searched through the [issue tracker] for duplicates
  • I have mentioned version numbers, operating system and
    environment, where applicable:

Recent versions of vscode support ipywidgets. It could be that the autonotebook code that was introduced in this PR now can be reverted. I note that comments on the end of that indicate there should be a new issue, but I didn't spot it.

If the authors feel comfortable with this idea, I can do the work to submit a PR.
@casperdcl
Copy link
Member

Ah yes was also mentioned in #751 (comment). Happy to accept a PR if you can find out the minimum version supported!

@casperdcl casperdcl added p3-enhancement 🔥 Much new such feature submodule-notebook 📓 Much web such IDE labels Jul 29, 2021
@gordonwatts
Copy link
Author

Ok. I think the tricky part will actually be knowing what version of VS CODE is running inside the notebook. I'll hunt around and see if I can find something.

@aldanor
Copy link
Contributor

aldanor commented Mar 16, 2022 •
edited
Loading

Any updates on that? Given the time that has passed, can we just remove that VSCODE_PID check?

Whichever the case, one the following will hold true for any user:

  1. autonotebook in the latest tqdm doesn't work properly with newer version of vscode (where "new" = over half a year now)
  2. autonotebook in the latest tqdm doesn't work properly in older versions of vscode

Given that (2) will dwindle over time and vscode tends to keep itself updated, can we just remove that single line from autonotebook.py, so that the latest vscode and the latest tqdm can live happily ever after?

@aldanor aldanor mentioned this issue Mar 16, 2022
Merged
@gordonwatts
Copy link
Author

Sorry - I would say yes. I guess it has been working well for me recently, so I'd stopped paying attention to this!

@casperdcl
Copy link
Member

fixed by #1309

@cbrnr cbrnr mentioned this issue Feb 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gordonwatts gordonwatts

Labels
p3-enhancement 🔥 Much new such feature submodule-notebook 📓 Much web such IDE
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

autonotebook: re-enable VSCode aldanor/tqdm
3 participants
@gordonwatts @aldanor @casperdcl