Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that PeekMaxMut has a parent before reading it #17

Merged
merged 1 commit into from
Dec 20, 2021

Conversation

cuviper
Copy link
Contributor

@cuviper cuviper commented Apr 22, 2021

Fixes #16.

@calebsander
Copy link
Contributor

This has been fixed in https://github.com/tov/min-max-heap-rs/pull/8/files#diff-b1a35a68f14e696205874893c07fd24fdb88882b47c23cc0e0c80a30c7d53759R766

@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2021

Codecov Report

Merging #17 (0812b36) into master (9aba91a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 0812b36 differs from pull request most recent head f9c0d89. Consider uploading reports for the commit f9c0d89 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master      #17   +/-   ##
=======================================
  Coverage   98.70%   98.71%           
=======================================
  Files           3        3           
  Lines         541      544    +3     
=======================================
+ Hits          534      537    +3     
  Misses          7        7           
Impacted Files Coverage Δ
src/lib.rs 97.97% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d92897...f9c0d89. Read the comment docs.

@tov
Copy link
Owner

tov commented Dec 20, 2021

Thanks, @cuviper! While the fix here is redundant with what @calebsander did in #8, your additions to one of the tests seem like something we should have, so I’m going to merge that.

@tov tov force-pushed the PeekMaxMut-has_parent branch from 0b056e9 to f9c0d89 Compare December 20, 2021 18:55
@tov tov merged commit d9f21d0 into tov:master Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PeekMaxMut::drop overflows when len==1
4 participants