Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SparseLinear does not call updateParameters and zeroGradParameters as defined in C #307

Open
eliemichel opened this issue Jul 2, 2015 · 0 comments
Open

SparseLinear does not call updateParameters and zeroGradParameters as defined in C #307

eliemichel opened this issue Jul 2, 2015 · 0 comments

Comments

@eliemichel
Copy link
Contributor

In SparseLinear.lua, methods updateParameters and zeroGradParameters are not defined and so inherited from nn.Module.

But these methods seems to be defined in the C code -- generic/SparseLinear.c -- and just never used.

I tried to overwrite these methods and call SparseLinear_updateParameters and SparseLinear_zeroGradParameter respectively, but a lastInput attribute is missing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eliemichel