Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Installation problem and wheels for Python 3.11 and 3.12 #49

Closed
juhoinkinen opened this issue Oct 4, 2023 · 3 comments · Fixed by #50
Closed

Installation problem and wheels for Python 3.11 and 3.12 #49

juhoinkinen opened this issue Oct 4, 2023 · 3 comments · Fixed by #50

Comments

@juhoinkinen
Copy link
Contributor

Could wheels be provided for Python 3.11 and just-released 3.12 to ease installation?

Also, I was unable to install Omikuji on Python 3.11 at all, due to a regexp error by Milksnake, see NatLibFi/Annif#703 (comment).

It might be that there will not be a new Milksnake release including the fix for this; it has alredy been some time since the fix has been merged to master. So, a least-effort option on Omikuji side seems to be to install current Milksnake master. (I checked this works.)

Alternatively, some projects have replaced Milksnake by Maturin, which might be a more involved, but also a long-term solution.

BTW, you might want also to update the classifiers for supported Python versions in setup.py too.
@tomtung
Copy link
Owner

tomtung commented Oct 14, 2023

Yeah migrating from milksnake to maturin is probably the way to go. I'll try figure out how to do this, but I've been a bit busy lately, so if you manage to figure it out in the meantime, please don't hesitate to open a pull request.

@juhoinkinen
Copy link
Contributor Author

Actually just a few days ago, Oct 12, milksnake v0.1.6 was published on PyPI, which seems to include the required fix. The new version is used e.g. in getsentry/relay#2599.

So for having support for Python 3.11 and 3.12 I think milksnake is still usable.

Anyway, I'll open a PR just for the 3.11 and 3.12 support. I could look at the maturin migration at later time, but I don't have any experience on Rust programs, so it might take some time.

@juhoinkinen juhoinkinen mentioned this issue Oct 16, 2023
Merged
@tomtung
Copy link
Owner

tomtung commented Oct 30, 2023

New wheels published with version 0.5.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Build wheels for Python 3.11 and 3.12, remove Python 3.7 builds and support juhoinkinen/omikuji
2 participants
@tomtung @juhoinkinen